If one is using Seen/Unseen renewals and has the RenewAccruingItemWhenPaid system preference enabled, upon accepting payment for an accruing overdue fine the item will be automatically renewed and that renewal will be considered "seen," as if the patron had actually brought the item to the library. That seems like a faulty assumption. An automatically-triggered renewal should be unseen.
Created attachment 134897 [details] [review] Bug 29021: RenewAccruingItemWhenPaid renewals are not seen This patch updates the call to AddRewewal from Koha::Accounts to makr the renewal as unseen.
Created attachment 144503 [details] [review] Bug 29021: RenewAccruingItemWhenPaid renewals are not seen This patch updates the call to AddRewewal from Koha::Accounts to makr the renewal as unseen. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 145761 [details] [review] Bug 29021: RenewAccruingItemWhenPaid renewals are not seen This patch updates the call to AddRewewal from Koha::Accounts to makr the renewal as unseen. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 145762 [details] [review] Bug 29021: (QA follow-up) Fix for new parameter, add unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 145799 [details] [review] Bug 29021: (QA follow-up) Remove useless warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.10
I should not have backported this, tests are failing because there is no 'Koha::Checkouts::Renewals' in 22.05. That looks like it was added by Bug 30275. I will revert this patchset from 22.05.x.
Patchset reverted from 22.05.x
Same as Lukas, can't backport