Bug 29021 - Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen
Summary: Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Martin Renvoize
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 24083 30275
Blocks:
  Show dependency treegraph
 
Reported: 2021-09-14 17:59 UTC by Andrew Fuerste-Henry
Modified: 2023-12-28 20:43 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen (786 bytes, patch)
2022-05-11 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen (852 bytes, patch)
2022-12-08 15:52 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen (908 bytes, patch)
2023-01-27 16:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29021: (QA follow-up) Fix for new parameter, add unit test (1.50 KB, patch)
2023-01-27 16:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29021: (QA follow-up) Remove useless warnings (1.43 KB, patch)
2023-01-30 15:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2021-09-14 17:59:46 UTC
If one is using Seen/Unseen renewals and has the RenewAccruingItemWhenPaid system preference enabled, upon accepting payment for an accruing overdue fine the item will be automatically renewed and that renewal will be considered "seen," as if the patron had actually brought the item to the library. That seems like a faulty assumption. An automatically-triggered renewal should be unseen.
Comment 1 Martin Renvoize 2022-05-11 14:53:26 UTC
Created attachment 134897 [details] [review]
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen

This patch updates the call to AddRewewal from Koha::Accounts to makr
the renewal as unseen.
Comment 2 PTFS Europe Sandboxes 2022-12-08 15:52:49 UTC
Created attachment 144503 [details] [review]
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen

This patch updates the call to AddRewewal from Koha::Accounts to makr
the renewal as unseen.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Kyle M Hall 2023-01-27 16:59:08 UTC
Created attachment 145761 [details] [review]
Bug 29021: RenewAccruingItemWhenPaid renewals are not seen

This patch updates the call to AddRewewal from Koha::Accounts to makr
the renewal as unseen.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall 2023-01-27 16:59:55 UTC
Created attachment 145762 [details] [review]
Bug 29021: (QA follow-up) Fix for new parameter, add unit test

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-01-30 15:05:07 UTC
Created attachment 145799 [details] [review]
Bug 29021: (QA follow-up) Remove useless warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2023-01-30 15:15:33 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-01-31 17:19:21 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Lucas Gass 2023-02-01 19:10:57 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 9 Lucas Gass 2023-02-02 16:53:27 UTC
I should not have backported this, tests are failing because there is no 'Koha::Checkouts::Renewals' in 22.05. That looks like it was added by Bug 30275. I will revert this patchset from 22.05.x.
Comment 10 Lucas Gass 2023-02-02 16:57:07 UTC
Patchset reverted from 22.05.x
Comment 11 Arthur Suzuki 2023-02-17 09:45:26 UTC
Same as Lukas, can't backport