To recreate: 1 - turn on UnseenRenewals 2- confirm AllowRenewalLimitOverride is off 3- set your all/all rule to allow 1 unseen renewal, more than 1 regular renewal 4- check item out to patron, make sure you're following the all/all rule 5- renew item from OPAC as patron 6- confirm OPAC and intranet tell you next renewal must be at library but that you have renewals remaining 7- try to renew with the Renew Selected button in the Checkouts tab, you cannot select this checkout 8- try to renew with the Renew All button in the Checkouts tab, the item does not renew 9- try to check the item out to the patron again, get message "No more renewals possible" 10 - try to renew by putting the barcode in the big Renew box at the top of the page, get message "E Street shuffle : ( 1 ) has been renewed the maximum number of consecutive times without being seen by the library )" That leaves staff with no way to perform a Seen renewal and reset the count un Unseen renewals, which means the patron is stuck and the item must be returned, which makes this feature deeply flawed.
Hmm, this looks like a regression.. I agree it should allow for renewal in the staff client as seen.
Created attachment 134898 [details] [review] Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed.
Created attachment 134899 [details] [review] Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate
OK, those two patches should resolve: 7- try to renew with the Renew Selected button in the Checkouts tab, you cannot select this checkout 8- try to renew with the Renew All button in the Checkouts tab, the item does not renew Still working on the other avenues.
I'm not sure about the other two.. we don't have a clear way of saying "This wasn't a seen renewal" for them (On the table version we default to 'seen' but you have the checkbox to set 'unseen' and we handle it nicely as a result).. For the search header renew, perhaps we're OK to always assume it's 'seen' (as in theory you are always scanning into that box), but for the normal Checkout way it could be via a search.. so maybe we should not always assume 'seen' or at least give the option to do an 'unseen' at this point.. think about telephone renewals as a workflow.. What do you think Andrew?
(In reply to Martin Renvoize from comment #5) > I'm not sure about the other two.. we don't have a clear way of saying "This > wasn't a seen renewal" for them (On the table version we default to 'seen' > but you have the checkbox to set 'unseen' and we handle it nicely as a > result).. > > For the search header renew, perhaps we're OK to always assume it's 'seen' > (as in theory you are always scanning into that box), but for the normal > Checkout way it could be via a search.. so maybe we should not always assume > 'seen' or at least give the option to do an 'unseen' at this point.. think > about telephone renewals as a workflow.. > > What do you think Andrew? Not Andrew, but I assume this is OK. This at least leaves staff with a way to do a seen renewal.
I reckon go with this for now and work on the other bits as a distinct bug.. I've run out of time to continue here.
Created attachment 136780 [details] [review] Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com>
Created attachment 136782 [details] [review] Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com>
7 and 8 work with the patch! Thanks Andrew and Martin, this is major
Created attachment 137271 [details] [review] Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 137272 [details] [review] Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.05
pushed to 21.11.x for 21.11.12
Backported: Pushed to 21.05.x branch for 21.05.19 Nothing to document I think.