29108 – Add q parameters to items routes

Bug 29108 - Add q parameters to items routes

Summary: Add q parameters to items routes

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	REST API (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Tomás Cohen Arazi (tcohen)
QA Contact:	Martin Renvoize (ashimema)

URL:
Keywords:

Depends on:	29107
Blocks:
	Show dependency tree / graph

Reported:	2021-09-24 12:03 UTC by Tomás Cohen Arazi (tcohen)
Modified:	2022-06-06 20:25 UTC (History)
CC List:	3 users (show)

See Also:	29105
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	21.11.00
Circulation function:

Attachments
Bug 29108: Add q parameters to items routes (24.12 KB, patch) 2021-09-24 12:07 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Bug 29108: Add q parameters to items routes (24.20 KB, patch) 2021-09-24 14:52 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomás Cohen Arazi (tcohen) 2021-09-24 12:03:23 UTC

Comment 1 Tomás Cohen Arazi (tcohen) 2021-09-24 12:07:47 UTC

Created attachment 125237 [details] [review]
Bug 29108: Add q parameters to items routes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 2 Martin Renvoize (ashimema) 2021-09-24 14:34:05 UTC

This is great to see.. but as discussed, with bug 29105 in mind we need to think about how we overload the existing API search method to allow for the item-level_itypes mapping in searches.

Comment 3 Tomás Cohen Arazi (tcohen) 2021-09-24 14:45:38 UTC

Well, this one stands on its own. We should move the discussion about the search override to bug 29105.

Comment 4 Martin Renvoize (ashimema) 2021-09-24 14:52:01 UTC

Created attachment 125254 [details] [review]
Bug 29108: Add q parameters to items routes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 5 Martin Renvoize (ashimema) 2021-09-24 14:52:39 UTC

Fair.. signed off then.

Comment 6 Martin Renvoize (ashimema) 2021-09-30 10:26:28 UTC

This is another trivial really.. going straight for QA

Comment 7 Jonathan Druart 2021-10-28 15:45:09 UTC

Pushed to master for 21.11, thanks to everybody involved!