Bug 29129 - The clear screen and print icons in circulation should be configurable to print either ISSUESLIP or ISSUEQSLIP
Summary: The clear screen and print icons in circulation should be configurable to pri...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 34684
  Show dependency treegraph
 
Reported: 2021-09-28 15:58 UTC by Lucas Gass
Modified: 2023-09-01 07:44 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/616
Text to go in the release notes:
This enhancement expands upon the 'DisplayClearScreenButton' allowing the choice of printing either the ISSUESLIP or the ISSUEQSLIP when using the printclearscreen icon.
Version(s) released in:
22.11.00


Attachments
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip (7.63 KB, patch)
2022-04-27 18:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip (7.69 KB, patch)
2022-04-27 18:56 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip (7.75 KB, patch)
2022-04-28 16:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 29129: (QA follow-up) Add +x to atomicupdate permissions (623 bytes, patch)
2022-04-28 16:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 29129: (QA follow-up): Fix tiny typo in system preference description (1.23 KB, patch)
2022-04-28 16:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 29129: (QA follow-up) Rephrasing DisplayClearScreenButton preference (1.56 KB, patch)
2022-04-28 16:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 29129: (QA follow-up) Tidy atomicupdate (1.72 KB, patch)
2022-06-25 14:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2021-09-28 15:58:33 UTC
The printclearscreen icon which appears when the system preference 'DisplayClearScreenButton' should allow users to choose between printing the ISSUESLIP and ISSUEQSLIP, if that system pref is turned on. 

I think the 'DisplayClearScreenButton' could have 3 options:
-Don't show
-Show and print ISSUESLIP
-Show and print ISSUEQSLIP
Comment 1 Andrew Fuerste-Henry 2022-04-01 21:27:53 UTC
+!
Comment 2 Lucas Gass 2022-04-27 18:01:24 UTC
Created attachment 134175 [details] [review]
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip

To Test:
1. Apply patch, updatedatabase, and restart_all
2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Set DisplayClearScreenButton to "don't show"
4. Go to the patron checkout screen and see that no button should show to clear the screen and print
5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints
6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints
Comment 3 Andrew Fuerste-Henry 2022-04-27 18:56:50 UTC
Created attachment 134176 [details] [review]
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip

To Test:
1. Apply patch, updatedatabase, and restart_all
2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Set DisplayClearScreenButton to "don't show"
4. Go to the patron checkout screen and see that no button should show to clear the screen and print
5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints
6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 4 Katrin Fischer 2022-04-28 15:13:57 UTC
Please remember to run QA test tools:
 OK	circ/circulation.pl
 FAIL	installer/data/mysql/atomicupdate/bug29129.pl
   FAIL	  file permissions
		File must have the exec flag
Comment 5 Katrin Fischer 2022-04-28 16:18:51 UTC
Created attachment 134282 [details] [review]
Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip

To Test:
1. Apply patch, updatedatabase, and restart_all
2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Set DisplayClearScreenButton to "don't show"
4. Go to the patron checkout screen and see that no button should show to clear the screen and print
5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints
6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2022-04-28 16:18:56 UTC
Created attachment 134283 [details] [review]
Bug 29129: (QA follow-up) Add +x to atomicupdate permissions

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-04-28 16:19:01 UTC
Created attachment 134284 [details] [review]
Bug 29129: (QA follow-up): Fix tiny typo in system preference description

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2022-04-28 16:19:07 UTC
Created attachment 134285 [details] [review]
Bug 29129: (QA follow-up) Rephrasing DisplayClearScreenButton preference

Trying to make it clearer that's either none or 2 buttons.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2022-04-28 16:19:50 UTC
Hi Lucas, maybe you can have a look at my last follow-up and let me know if that works for you?
Comment 10 Fridolin Somers 2022-05-05 21:55:45 UTC
Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP
This will avoid a new system preference.
Comment 11 Lucas Gass 2022-05-05 22:06:29 UTC
(In reply to Fridolin Somers from comment #10)
> Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP
> This will avoid a new system preference.

I will rework this to just always show all 3, without a sys pref.
Comment 12 Katrin Fischer 2022-05-06 09:48:06 UTC
(In reply to Lucas Gass from comment #11)
> (In reply to Fridolin Somers from comment #10)
> > Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP
> > This will avoid a new system preference.
> 
> I will rework this to just always show all 3, without a sys pref.

We already have the pref, so it's just a new option to an existing one.

I feel that libraries have prefernces about the slips and we'd need really clear icons for full and quick slip printing. Not sure if that would not be worth to be discussed/done later and let this in as a small change to an already existing feature.
Comment 13 Fridolin Somers 2022-05-07 06:08:36 UTC
> We already have the pref, so it's just a new option to an existing one.
> 

Ohhh i totally missed that.
In this case OK to add a new option, sure
Comment 14 Tomás Cohen Arazi 2022-06-25 14:15:43 UTC
Created attachment 136551 [details] [review]
Bug 29129: (QA follow-up) Tidy atomicupdate

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 15 Tomás Cohen Arazi 2022-06-25 14:18:04 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 16 Lucas Gass 2022-07-29 16:15:06 UTC
Enhancement will not be backported to 22.05.x series unless requested