To recreate: -Go to Tools and open either addtional contents ( either News or HTML customization ) -Make sure you open it using CodeMirror and not TinyMCE -Code mirror is broken
Created attachment 126368 [details] [review] Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work.
Created attachment 126390 [details] [review] Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 126463 [details] [review] Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!