Go to members/moremember.pl for a patron who has messaging preferences set. Notice in the messaging preferences that the digest column displays as active (showing either the blue checkmark or a white box). Click on one of the digests and see that you can change it (which is bad). Navigate away from the page, return to it, and see that changes are not reflected (which is good) This column should not be active/appear to be editable from this screen - it should only be editable through the modification screens like the rest of the preferences in the table.
Created attachment 126275 [details] [review] Bug 29227: Patron messaging preferences digest show as editable but are not On moremember.pl we load the messaging preferences for display only, we do not need to load the JS for editing the preferences To test: 0 - Enable EnhancedMessagingPreferences 1 - Load the detais tab for a member 2 - Note the digest column in messaging preferences is clickable 3 - Apply patch 4 - Reload, it is not clickable 5 - Confirm editing the patron (or their messaging prefs) works as expected
Created attachment 126310 [details] [review] Bug 29227: Patron messaging preferences digest show as editable but are not On moremember.pl we load the messaging preferences for display only, we do not need to load the JS for editing the preferences To test: 0 - Enable EnhancedMessagingPreferences 1 - Load the detais tab for a member 2 - Note the digest column in messaging preferences is clickable 3 - Apply patch 4 - Reload, it is not clickable 5 - Confirm editing the patron (or their messaging prefs) works as expected Signed-off-by: David Nind <david@davidnind.com>
Created attachment 126803 [details] [review] Bug 29227: Patron messaging preferences digest show as editable but are not On moremember.pl we load the messaging preferences for display only, we do not need to load the JS for editing the preferences To test: 0 - Enable EnhancedMessagingPreferences 1 - Load the detais tab for a member 2 - Note the digest column in messaging preferences is clickable 3 - Apply patch 4 - Reload, it is not clickable 5 - Confirm editing the patron (or their messaging prefs) works as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.12
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.