Testing the built-in offline circulation system in a browser which still supports applicationCache, I ran into this error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84
Created attachment 126373 [details] [review] Bug 29255: Built-in offline circulation broken with SQL error This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information.
It wasn't until I tested this in a new instance of KTD that this ALSO suffers from SQL errors if SQL strict mode is on, so please test with strict mode off.
The strict mode problem is now described in Bug 29371.
Created attachment 127179 [details] [review] Bug 29255: Built-in offline circulation broken with SQL error This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 127607 [details] [review] Bug 29255: Built-in offline circulation broken with SQL error This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.12
Backported: Pushed to 20.05.x branch for 20.05.18
Not backporting to 19.11.x - LTS version will just backport security patches