I would like to update serials-search.tt so that it has consistent indentation.
Created attachment 126662 [details] [review] Bug 29299: Reindent serials search template This patch updates the serials search template to give it consistent indentation. The patch also moves one section of markup: The <tfoot> section is moved to after <tbody> in order to conform to current standards. To test, apply the patch and go to Serials -> Search subscriptions (in the header). - Serials search should work correctly and the page should look correct. - With Mana enabled, click on the "Search on Mana" link in the sidebar. - Searches of Mana should work correctly too. - If you view the diff while ignoring whitespace the only changes should be the move of <tfoot> and places where line breaks were introduced.
Created attachment 126663 [details] [review] Bug 29299: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality.
Created attachment 126677 [details] [review] Bug 29299: Reindent serials search template This patch updates the serials search template to give it consistent indentation. The patch also moves one section of markup: The <tfoot> section is moved to after <tbody> in order to conform to current standards. To test, apply the patch and go to Serials -> Search subscriptions (in the header). - Serials search should work correctly and the page should look correct. - With Mana enabled, click on the "Search on Mana" link in the sidebar. - Searches of Mana should work correctly too. - If you view the diff while ignoring whitespace the only changes should be the move of <tfoot> and places where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 126678 [details] [review] Bug 29299: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 126798 [details] [review] Bug 29299: Reindent serials search template This patch updates the serials search template to give it consistent indentation. The patch also moves one section of markup: The <tfoot> section is moved to after <tbody> in order to conform to current standards. To test, apply the patch and go to Serials -> Search subscriptions (in the header). - Serials search should work correctly and the page should look correct. - With Mana enabled, click on the "Search on Mana" link in the sidebar. - Searches of Mana should work correctly too. - If you view the diff while ignoring whitespace the only changes should be the move of <tfoot> and places where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 126799 [details] [review] Bug 29299: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!