Bug 29318 - OverDrive search page should not require edit_borrowers permission
Summary: OverDrive search page should not require edit_borrowers permission
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-25 18:45 UTC by Nick Clemens (kidclamp)
Modified: 2022-06-06 20:29 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.11.00
Circulation function:

Attachments
Bug 29318: Remove permission check from overdrive search page (1.62 KB, patch)
2021-10-25 18:51 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 29318: Tidy the code (1.37 KB, patch)
2021-10-25 18:51 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 29318: Remove permission check from overdrive search page (1.67 KB, patch)
2021-10-25 19:05 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 29318: Tidy the code (1.42 KB, patch)
2021-10-25 19:05 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 29318: Remove permission check from overdrive search page (1.73 KB, patch)
2021-10-25 20:29 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 29318: Tidy the code (1.47 KB, patch)
2021-10-25 20:29 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2021-10-25 18:45:13 UTC 
This seems to have been introduced with the feature in bug 10320, and updated with bug 18403
Comment 1 Nick Clemens (kidclamp) 2021-10-25 18:51:25 UTC 
Created attachment 126840 [details] [review]
Bug 29318: Remove permission check from overdrive search page

This removes the 'edit_borrowers' permission from OverDrive search

To test:
1 - Enable OverDrive via koha system preferences
2 - Sign in to opac with a user with no permissions
3 - Perform a search that will return OD results, 'love' works
4 - Click thje "Found XX results in the library's OverDrive collection"
5 - Note you are logged out of Koha
6 - Apply patch
7 - Repeat
8 - Success
Comment 2 Nick Clemens (kidclamp) 2021-10-25 18:51:28 UTC 
Created attachment 126841 [details] [review]
Bug 29318: Tidy the code
Comment 3 Owen Leonard 2021-10-25 19:05:53 UTC 
Created attachment 126842 [details] [review]
Bug 29318: Remove permission check from overdrive search page

This removes the 'edit_borrowers' permission from OverDrive search

To test:
1 - Enable OverDrive via koha system preferences
2 - Sign in to opac with a user with no permissions
3 - Perform a search that will return OD results, 'love' works
4 - Click thje "Found XX results in the library's OverDrive collection"
5 - Note you are logged out of Koha
6 - Apply patch
7 - Repeat
8 - Success

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2021-10-25 19:05:57 UTC 
Created attachment 126843 [details] [review]
Bug 29318: Tidy the code

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Katrin Fischer 2021-10-25 20:29:09 UTC 
Created attachment 126849 [details] [review]
Bug 29318: Remove permission check from overdrive search page

This removes the 'edit_borrowers' permission from OverDrive search

To test:
1 - Enable OverDrive via koha system preferences
2 - Sign in to opac with a user with no permissions
3 - Perform a search that will return OD results, 'love' works
4 - Click thje "Found XX results in the library's OverDrive collection"
5 - Note you are logged out of Koha
6 - Apply patch
7 - Repeat
8 - Success

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2021-10-25 20:29:14 UTC 
Created attachment 126850 [details] [review]
Bug 29318: Tidy the code

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2021-10-25 20:30:01 UTC 
Couldn't test with Overdrive, but trusting Owen has. Code reads well and a permission check definitely makes no sense in an OPAC script.
Comment 8 Jonathan Druart 2021-10-26 14:22:25 UTC 
So basically this script has never been used?
Comment 9 Jonathan Druart 2021-10-26 14:42:19 UTC 
Pushed to master for 21.11, thanks to everybody involved!