Bug 29348 - GetOtherReserves fails to mark holds as waiting or in-transit
Summary: GetOtherReserves fails to mark holds as waiting or in-transit
Status: RESOLVED DUPLICATE of bug 34972
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-28 12:28 UTC by Nick Clemens (kidclamp)
Modified: 2024-04-22 20:55 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2021-10-28 12:28:59 UTC
ModReserveCancelAll is called when a hold is cancelled from the waiting holds list 

This in turn calls GetOtherReserves

GetOtherReserves then calls ModReserveMinusPriority which sets the priority to 0 and then calls _FixPriority

The problem is that 'found' is still null for the holds - so it is processed by _FixPriority and has its' priority increased by 1 - this prevents it from being marked waiting or in transit by subsequent code

This leaves holds in an odd state where they have an itemnumber, but no status - okay for an item level hold - but bad for bib level

To recreate:
1 - Place a bib level hold for 3 different patrons on the same bib
    The first two should be picked up at logged in branch, the third elsewhere
2 - Check-in and confirm the hold
3 - Go to Circulation->Holds awaiting pickup
4 - Cancel the hold - you get a popup asking you to check in the item to process the hold
5 - View the biblio - see that hold has an itemnumber, but no status
6 - Check in the item, confirm the hold, cancel from waiting reserves
7 - View the biblio - third hold has the itemnumber, but no status

While we do say in the message "Check this in to process the hold" the code indicates it will start the transfer or set the hold waiting.
Comment 1 Emily Lamancusa 2024-04-22 20:55:20 UTC

*** This bug has been marked as a duplicate of bug 34972 ***