When viewing 'All' branches for the holds queue, it would be nice to be able to see which branch the item is located in
Created attachment 127212 [details] [review] Bug 29389: Add holding branch to the holds queue report This patch adds the holding branch to the hold queue report. It is added as hidden by default, when running per branch it is not needed To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no holding branch column 5 - Apply patch 6 - Reload 7 - Note the column is not there 8 - Click column setting gear 9 - Check the column and confirm it appears 10 - Confirmthe filter works
Thx :)
I don't think the new column should be first. Title is almost always first in tables like this and I think we should keep it consistent. The new column should be called "Current library" to be consistent with the detail page and holds awaiting pickup.
Created attachment 140828 [details] [review] Bug 29389: Add holding branch to the holds queue report This patch adds the holding branch to the hold queue report. It is added as hidden by default, when running per branch it is not needed To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no 'Current library' column 5 - Apply patch 6 - Reload 7 - Note the column is not there 8 - Click column setting gear 9 - Check the column and confirm it appears 10 - Confirm the filter works
Created attachment 140829 [details] [review] Bug 29389: Add holding branch to the holds queue report This patch adds the holding branch to the hold queue report. It is added as hidden by default, when running per branch it is not needed To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no 'Current library' column 5 - Apply patch 6 - Reload 7 - Note the column is not there 8 - Click column setting gear 9 - Check the column and confirm it appears 10 - Confirm the filter works
Created attachment 140835 [details] [review] Bug 29389: Add holding branch to the holds queue report This patch adds the holding branch to the hold queue report. It is added as hidden by default, when running per branch it is not needed To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no 'Current library' column 5 - Apply patch 6 - Reload 7 - Note the column is not there 8 - Click column setting gear 9 - Check the column and confirm it appears 10 - Confirm the filter works Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 141201 [details] [review] Bug 29389: Add holding branch to the holds queue report This patch adds the holding branch to the hold queue report. It is added as hidden by default, when running per branch it is not needed To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no 'Current library' column 5 - Apply patch 6 - Reload 7 - Note the column is not there 8 - Click column setting gear 9 - Check the column and confirm it appears 10 - Confirm the filter works Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!