Created attachment 127266 [details] Screenshot of a search results entry for a suppressed record In both staff interface search results and on the bibliographic detail page the "Suppressed in OPAC" message is shown at the top of the record. I think it makes more sense to show it with the other bibliographic details.
Created attachment 127267 [details] Screenshot of a detail view for a suppressed record
Created attachment 127268 [details] [review] Bug 29406: Improve display of OPAC suppression message This patch changes the way the "Suppressed in OPAC" message is shown on the staff interface search results and the bibliographic detail page. Now the information is displayed like other bibliographic details. To test, apply the patch and restart services. - Enable the OpacSuppression system preference and modify at least one record to be suppressed in the OPAC (942$n in MARC21). - Perform a catalog search which will return this record in the staff client. - The entry for that record in the search results should include the message "Suppressed in OPAC" at the bottom of the list of other bibliographic details. - View the details for that record. You should see a line labeled "OPAC view" It should say "Suppressed in OPAC." - Test a record which is not suppressed. If you have OPACBaseURL populated you should see "OPAC view: Open in new window."
Created attachment 127406 [details] [review] Bug 29406: Improve display of OPAC suppression message This patch changes the way the "Suppressed in OPAC" message is shown on the staff interface search results and the bibliographic detail page. Now the information is displayed like other bibliographic details. To test, apply the patch and restart services. - Enable the OpacSuppression system preference and modify at least one record to be suppressed in the OPAC (942$n in MARC21). - Perform a catalog search which will return this record in the staff client. - The entry for that record in the search results should include the message "Suppressed in OPAC" at the bottom of the list of other bibliographic details. - View the details for that record. You should see a line labeled "OPAC view" It should say "Suppressed in OPAC." - Test a record which is not suppressed. If you have OPACBaseURL populated you should see "OPAC view: Open in new window." Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
There is a bug (#26861) to indicate that a record is using OpacHiddenItems in staff client. Once that functionality gets created it seems like the display for "Hidden in OPAC" could be handled in the same way as this bug. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861
This is trivial but I just noticed that there is an unnecessary period at the end of "Open in new window." which I don't think really needs to be there.
Created attachment 127491 [details] [review] Bug 29406: Improve display of OPAC suppression message This patch changes the way the "Suppressed in OPAC" message is shown on the staff interface search results and the bibliographic detail page. Now the information is displayed like other bibliographic details. To test, apply the patch and restart services. - Enable the OpacSuppression system preference and modify at least one record to be suppressed in the OPAC (942$n in MARC21). - Perform a catalog search which will return this record in the staff client. - The entry for that record in the search results should include the message "Suppressed in OPAC" at the bottom of the list of other bibliographic details. - View the details for that record. You should see a line labeled "OPAC view" It should say "Suppressed in OPAC." - Test a record which is not suppressed. If you have OPACBaseURL populated you should see "OPAC view: Open in new window." Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 22.05, thanks to everybody involved!
Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details.