Bug 2941 - Transfers cannot be canceled once initiated.
Summary: Transfers cannot be canceled once initiated.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-03 06:14 UTC by Chris Cormack
Modified: 2012-10-25 23:03 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (4.62 KB, patch)
2011-04-22 19:40 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:04:33 UTC


---- Reported by rch@liblime.com 2009-02-03 18:14:36 ----

If a hold is placed at library B for an item at library A,
once library A checks in the item and initiates the transfer,
further check-ins prompt only to send the item to library B,
even if the hold that triggered the transfer has been canceled.

I suggest two solutions to this problem:  
(1) if a transfer is in progress, checking in at the originating
library should offer a cancellation of transfer.
(2) moredetail.pl  does NOT currently report any transfer information.
If an item is in transit, it should be reported here, and the user should
be able to cancel a transfer from this screen, reverting holdingbranch to
the transfer initiating branch.  (or, minimally, the in-transit status
should be reported, and a check-in should offer a cancel-transfer option).



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:04 UTC  ---

This bug was previously known as _bug_ 2941 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2941
This bug depended on bug(s) 3270.

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was rch@liblime.com.

Comment 1 Chris Cormack 2010-10-12 23:45:39 UTC
I'm going to be doing some work on this. Grabbing the assignment
Comment 2 Chris Cormack 2010-10-13 00:08:06 UTC
The moredetail page now is displaying the transfer status, still working on this, but the branch its being worked on is

http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/bug_2941

Based on master, so feel free to clone and test. I hope to push more to it today.
Comment 3 Chris Cormack 2010-10-13 02:07:35 UTC
Right its now working, you can cancel a transfer from returns (check in) and from the moredetail.pl screen

Will submit for 3.4, but for now you can merge the branch for that feature
Comment 4 Owen Leonard 2011-04-22 19:40:35 UTC
Created attachment 3993 [details] [review]
Proposed fix

I took the changes I found in that Catalyst branch Chris linked to and added a couple of additional changes:

- A link on transferstoreceive.pl to cancel a pending transfer from there
- A redirect so that clicking the link on transferstoreceive.pl will return the
  user to transferstoreceive.pl instead of returns.pl

Is there anything I'm missing that has otherwise prevented this from being submitted previously?
Comment 5 Chris Cormack 2011-05-13 02:20:37 UTC
This is in master, and went out in the 3.4.0 release 

commit 091cd69f44e871990d511917d4aa93960fea567f