From the Submit a New Purchase Suggestion function, if the system recognizes the title in one way or another, the system will give the patron the message s message before proceeding with the purchase suggestion: A similar document already exists. Click on confirm your suggestion to ignore this message. At this point, the (document)item type has gone back to, "None." If the patron scrolls down and clicks on "Confirm your suggestion" anyways, and doesn't change the item type a second time, then this is where the system allows for the suggestion to be submitted without the item type. The item type needs to be retained.
Created attachment 127684 [details] [review] Bug 29419: Retain user's inputs when suggesting for purchase and match found If a user suggests for purchase and a match is found, their inputs was not retained: quantity, item type, library, reason. Test plan: 1. Suggest for purchase 2. Fill the title in with a string that will match an existing record 3. Fill value in quantity, item type, library and reason input/dropdown 4. Submit => Notice that with this patch the values you entered are retained on the confirmation screen
Created attachment 128482 [details] [review] Bug 29419: Retain user's inputs when suggesting for purchase and match found If a user suggests for purchase and a match is found, their inputs was not retained: quantity, item type, library, reason. Test plan: 1. Suggest for purchase 2. Fill the title in with a string that will match an existing record 3. Fill value in quantity, item type, library and reason input/dropdown 4. Submit => Notice that with this patch the values you entered are retained on the confirmation screen Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 128700 [details] [review] Bug 29419: Retain user's inputs when suggesting for purchase and match found If a user suggests for purchase and a match is found, their inputs was not retained: quantity, item type, library, reason. Test plan: 1. Suggest for purchase 2. Fill the title in with a string that will match an existing record 3. Fill value in quantity, item type, library and reason input/dropdown 4. Submit => Notice that with this patch the values you entered are retained on the confirmation screen Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
When pushing master, had a little conflict because of Bug 26296 But changes are not related, not on same line.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Pushed to 21.05.x for 21.05.09
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.