Bug 29449 - Show userid on "your personal details" tab
Summary: Show userid on "your personal details" tab
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Magnus Enger
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-10 10:11 UTC by Magnus Enger
Modified: 2023-12-28 20:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Patrons can now see their username in the 'Personal details' tab in the OPAC. This can be hidden from them using the PatronSelfModificationBorrowerUnwantedField system preference, if needed.
Version(s) released in:
23.05.00


Attachments
Bug 29449: Show userid on "Personal details" tab (1.73 KB, patch)
2023-02-22 09:34 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 29449: Show userid on "Personal details" tab (2.06 KB, patch)
2023-02-23 08:59 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 29449: Show userid on "Personal details" tab (2.00 KB, patch)
2023-02-23 09:00 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 29449: Show userid on "Personal details" tab (2.07 KB, patch)
2023-03-08 18:59 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 29449: Show userid on "Personal details" tab (2.13 KB, patch)
2023-03-24 17:28 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2021-11-10 10:11:38 UTC
In the OPAC, the "your personal details" tab of a logged in user shows the card number, but not the userid. This is extra confusing for users who have their username generated in the firstname.surname form. 

I can't think of cases where a library would want to hide the userid from patrons, but if there are any arguments for this, there would have to be a syspref (or a per patron category setting?) to enable/disable the display.
Comment 1 Katrin Fischer 2021-11-10 11:44:54 UTC
We already have the "*unwanted*" prefs for the OPAC and they also already list userid, but it's not displayed according to it, like you say. I'd almost say that this is a bug?
Comment 2 Magnus Enger 2023-02-22 09:34:15 UTC Comment hidden (obsolete)
Comment 3 Lucas Gass 2023-02-22 14:31:02 UTC
Works as described but when a patron self registers there is now an empty 'Username:'

Should we check to see if the action is 'edit' or not so that will not appear on the self registration form?
Comment 4 Magnus Enger 2023-02-23 07:17:54 UTC
(In reply to Lucas Gass from comment #3)
> Works as described but when a patron self registers there is now an empty
> 'Username:'
> 
> Should we check to see if the action is 'edit' or not so that will not
> appear on the self registration form?

Gah! I thought I checked that! It makes perfect sense of course. New patch coming.
Comment 5 Magnus Enger 2023-02-23 08:59:24 UTC Comment hidden (obsolete)
Comment 6 Magnus Enger 2023-02-23 09:00:31 UTC Comment hidden (obsolete)
Comment 7 Laura Escamilla 2023-03-06 12:15:39 UTC Comment hidden (obsolete)
Comment 8 ByWater Sandboxes 2023-03-08 18:59:20 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall 2023-03-24 17:28:07 UTC
Created attachment 148687 [details] [review]
Bug 29449: Show userid on "Personal details" tab

To reproduce:
- Login to the OPAC
- Go to the "Personal details" tab
- Verify the Username/userid of the logged in user is not
  shown anywhere

To test:
- Apply this patch
- Reload the "Personal details" tab
- Verify that "Username:" and the userid is now shown below the
  "Library card number"
- Try adding "userid" to PatronSelfModificationBorrowerUnwantedField
  and verify the field is hidden as expected
- Log out
- Go to "Don't have an account? Register here."
- Verify "Username:" is *not* shown
- Sign off

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Tomás Cohen Arazi 2023-03-31 10:17:33 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Marcel de Rooy 2023-04-05 13:10:36 UTC
Interesting!
I have a question: What would be the recommended way to use this in relation to the various borrower mandatory/unwanted settings?
I applied this change on 21.11 and still did not see userid.
Comment 12 Matt Blenkinsop 2023-04-11 11:24:04 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 13 Caroline Cyr La Rose 2023-05-24 16:05:58 UTC
Seems like a bug fix. Nothing to add/amend in the manual.