In the OPAC, the "your personal details" tab of a logged in user shows the card number, but not the userid. This is extra confusing for users who have their username generated in the firstname.surname form. I can't think of cases where a library would want to hide the userid from patrons, but if there are any arguments for this, there would have to be a syspref (or a per patron category setting?) to enable/disable the display.
We already have the "*unwanted*" prefs for the OPAC and they also already list userid, but it's not displayed according to it, like you say. I'd almost say that this is a bug?
Created attachment 147114 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Sign off
Works as described but when a patron self registers there is now an empty 'Username:' Should we check to see if the action is 'edit' or not so that will not appear on the self registration form?
(In reply to Lucas Gass from comment #3) > Works as described but when a patron self registers there is now an empty > 'Username:' > > Should we check to see if the action is 'edit' or not so that will not > appear on the self registration form? Gah! I thought I checked that! It makes perfect sense of course. New patch coming.
Created attachment 147195 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off https://bugs.koha-community.org/show_bug.cgi?id=32922
Created attachment 147196 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off
(In reply to Magnus Enger from comment #6) > Created attachment 147196 [details] [review] [review] > Bug 29449: Show userid on "Personal details" tab > > To reproduce: > - Login to the OPAC > - Go to the "Personal details" tab > - Verify the Username/userid of the logged in user is not > shown anywhere > > To test: > - Apply this patch > - Reload the "Personal details" tab > - Verify that "Username:" and the userid is now shown below the > "Library card number" > - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField > and verify the field is hidden as expected > - Log out > - Go to "Don't have an account? Register here." > - Verify "Username:" is *not* shown > - Sign off Signed-Off-By: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 147975 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 148687 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Interesting! I have a question: What would be the recommended way to use this in relation to the various borrower mandatory/unwanted settings? I applied this change on 21.11 and still did not see userid.
Enhancement - not backporting to 22.11.x Nice work everyone!
Seems like a bug fix. Nothing to add/amend in the manual.