Bug 29471 - MARC21: 520 - Summary etc. doesn't display in staff interface
Summary: MARC21: 520 - Summary etc. doesn't display in staff interface
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-12 16:08 UTC by Katrin Fischer
Modified: 2024-01-04 16:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 29471: Add display of MARC 520 to staff interface detail page (4.58 KB, patch)
2023-06-30 14:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 29471: Add display of MARC 520 to staff interface detail page (4.64 KB, patch)
2023-06-30 16:17 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 29471: Add display of MARC 520 to staff interface detail page (6.05 KB, patch)
2023-07-14 11:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 29471: Add display of MARC 520 to staff interface detail page (6.25 KB, patch)
2023-07-17 08:56 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2021-11-12 16:08:33 UTC
When the display for 520 was added to the OPAC, staff interface was missed.
Comment 1 Katrin Fischer 2023-06-30 14:24:40 UTC
Created attachment 152906 [details] [review]
Bug 29471: Add display of MARC 520 to staff interface detail page

At the moment 520 only displays in the OPAC. With this patch it
also displays in the staff interface detail page.

To test:
* Find a record with 520 or add some 520 entries to a record
  Note: different ind. 1 values will result in different labels
* View the record in the staff interface and the OPAC
* Verify only the OPAC shows the 520 entries
* Apply patch
* Verify now the staff interface displays them as well
Comment 2 Phil Ringnalda 2023-06-30 16:17:31 UTC
Created attachment 152908 [details] [review]
Bug 29471: Add display of MARC 520 to staff interface detail page

At the moment 520 only displays in the OPAC. With this patch it
also displays in the staff interface detail page.

To test:
* Find a record with 520 or add some 520 entries to a record
  Note: different ind. 1 values will result in different labels
* View the record in the staff interface and the OPAC
* Verify only the OPAC shows the 520 entries
* Apply patch
* Verify now the staff interface displays them as well

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Katrin Fischer 2023-06-30 17:07:31 UTC
Thank you, Phil!
Comment 4 Marcel de Rooy 2023-07-11 11:23:48 UTC
Moving to enh. Can understand the inital choice for normal btw.. But at the end every enhancement is a bug fix :)
Comment 5 Marcel de Rooy 2023-07-11 11:27:07 UTC
Patience is a good thing:

commit 668581b72022c6c0a46b6ccb5f607921f633e1f6
Author: Frédéric Demians <f.demians@tamil.fr>
Date:   Sun Nov 8 10:28:59 2009 +0100
    Improve detail page MARC21 XSL file for 505 and 520 tags
Comment 6 Marcel de Rooy 2023-07-11 11:29:49 UTC
+                <xsl:call-template name="subfieldSelect">
+                    <xsl:with-param name="codes">abcu</xsl:with-param>
+                </xsl:call-template>

520$u is a URL. Please adjust
Comment 7 Katrin Fischer 2023-07-11 11:35:25 UTC
(In reply to Marcel de Rooy from comment #6)
> +                <xsl:call-template name="subfieldSelect">
> +                    <xsl:with-param name="codes">abcu</xsl:with-param>
> +                </xsl:call-template>
> 
> 520$u is a URL. Please adjust

Can we do this separately? This is just a copy of the OPAC display.
Comment 8 Marcel de Rooy 2023-07-11 11:45:37 UTC
(In reply to Katrin Fischer from comment #7)
> (In reply to Marcel de Rooy from comment #6)
> > +                <xsl:call-template name="subfieldSelect">
> > +                    <xsl:with-param name="codes">abcu</xsl:with-param>
> > +                </xsl:call-template>
> > 
> > 520$u is a URL. Please adjust
> 
> Can we do this separately? This is just a copy of the OPAC display.

It is 5 minutes of work. Please do it here.
Comment 9 Katrin Fischer 2023-07-11 11:47:43 UTC
The problem is finding the 5 minutes currently, silly as it sounds... I'll try, but not sure when.
Comment 10 Katrin Fischer 2023-07-14 11:40:41 UTC
Created attachment 153474 [details] [review]
Bug 29471: Add display of MARC 520 to staff interface detail page

At the moment 520 only displays in the OPAC. With this patch it
also displays in the staff interface detail page.

To test:
* Find a record with 520 or add some 520 entries to a record
  Note: different ind. 1 values will result in different labels
* View the record in the staff interface and the OPAC
* Verify only the OPAC shows the 520 entries
* Apply patch
* Verify now the staff interface displays them as well

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Updated patch for displaying $u as link.
Comment 11 Katrin Fischer 2023-07-14 11:41:31 UTC
Marcel: I messed up the rebase so I ended up with only one patch. If you think it's needed, please push back to NSO.
Comment 12 Marcel de Rooy 2023-07-17 08:55:48 UTC
Just a side note, no blocker:

+                <xsl:if test="marc:subfield[@code='u']">
+                    <xsl:for-each select="marc:subfield[@code='u']">

The if test is fine, but actually not needed.
If you only have the foreach and there is no $u, nothing happens too.
Comment 13 Marcel de Rooy 2023-07-17 08:56:22 UTC
Created attachment 153528 [details] [review]
Bug 29471: Add display of MARC 520 to staff interface detail page

At the moment 520 only displays in the OPAC. With this patch it
also displays in the staff interface detail page.

To test:
* Find a record with 520 or add some 520 entries to a record
  Note: different ind. 1 values will result in different labels
* View the record in the staff interface and the OPAC
* Verify only the OPAC shows the 520 entries
* Apply patch
* Verify now the staff interface displays them as well

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Updated patch for displaying $u as link.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Restored signoff line from Phil. Change only for $u.
Comment 14 Katrin Fischer 2023-07-17 09:53:53 UTC
(In reply to Marcel de Rooy from comment #12)
> Just a side note, no blocker:
> 
> +                <xsl:if test="marc:subfield[@code='u']">
> +                    <xsl:for-each select="marc:subfield[@code='u']">
> 
> The if test is fine, but actually not needed.
> If you only have the foreach and there is no $u, nothing happens too.

You are right. Tbh I stole this code from another 5xx with $u for some consistency :)

Also thank you for adding back the sign-off line - I forgot about it when I rebased my local branch for the addition.
Comment 15 Tomás Cohen Arazi 2023-07-18 17:08:38 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 16 Martin Renvoize 2023-07-19 08:30:30 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 17 Matt Blenkinsop 2023-07-19 10:15:24 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x