Another find int he 21.11 translation files: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:81 This item belongs to another branch. branch should be library.
Created attachment 129570 [details] [review] Bug 29482: Replace the term branch with library This patch replaces the word "branch" with the word "library" in the self-checkout template, as per terminology guidelines. To test, apply the patch and go to Administration -> System preferences. - Set the "IndependentBranches" preference to "Yes." - Log into the self checkout system using a staff user with permission to do self-checkout but not superlibrarian status. - Try to check out an item which belongs to a library that's different to the one you're logged in with. - You should see a message, "Item cannot be checked out," including the text "This item belongs to another library."
Created attachment 129628 [details] [review] Bug 29482: Replace the term branch with library This patch replaces the word "branch" with the word "library" in the self-checkout template, as per terminology guidelines. To test, apply the patch and go to Administration -> System preferences. - Set the "IndependentBranches" preference to "Yes." - Log into the self checkout system using a staff user with permission to do self-checkout but not superlibrarian status. - Try to check out an item which belongs to a library that's different to the one you're logged in with. - You should see a message, "Item cannot be checked out," including the text "This item belongs to another library." Signed-off-by: David Nind <david@davidnind.com>
Testing notes (koha-testing-docker): - I couldn't get the user interface message to display by following the test plan: assume there are some other settings required - the message I got was "Sorry, this item cannot be checked out at this station." - Reviewed patch and signed off based on text changed to the correct terminology.
Created attachment 129825 [details] [review] Bug 29482: Replace the term branch with library This patch replaces the word "branch" with the word "library" in the self-checkout template, as per terminology guidelines. To test, apply the patch and go to Administration -> System preferences. - Set the "IndependentBranches" preference to "Yes." - Log into the self checkout system using a staff user with permission to do self-checkout but not superlibrarian status. - Try to check out an item which belongs to a library that's different to the one you're logged in with. - You should see a message, "Item cannot be checked out," including the text "This item belongs to another library." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Pushed to 21.05.x for 21.05.14
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.