The NumSavedReports system preference to set a custom default number of reports to show in Saved Reports isn't working in 21.05.04. Changing the number, saving, and then refreshing Saved Reports (or leaving then reentering the module) doesn't change the number shown from the system default of 20.
In dataTables version 1.10 we should use pageLength instead of iDisplayLength. https://datatables.net/reference/option/pageLength Koha is using 1.10.18
Created attachment 127677 [details] [review] Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work
Created attachment 127698 [details] [review] Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 127871 [details] [review] Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I bet is is since Bug 23013
Pushed to master for 22.05, thanks to everybody involved!
Pushed to 21.11.x for 21.11.01
Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details.
Pushed to 21.05.x for 21.05.08
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.