koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt var subfield=tagsubfieldid.substr(3,1); StrAlert += "<li>"+_("Tag %s subfield %s %s in tab %s").format(tag, subfield, formatFieldName( tabflag[tagsubfieldid][1] ), tabflag[tagsubfieldid][2]) + ' <a class="linkfield btn btn-link" href="#" data-tab="' + tabflag[tagsubfieldid][2] + '" data-field="' + tabflag[tagsubfieldid][3] + '"><i class="fa fa-arrow-right" aria-hidden="true"></i> Go to field</a></li>';
Created attachment 128066 [details] [review] Bug 29585: Fix unstranslatable strings in addbiblio.tt This patch makes 'Go to field' and 'Errors' strings translatable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
How can I test this? I thought this would work as I've tested things before for Owen, for example bug 26257. But those were for js strings. Before applying the patch ~~~~~~~~~~~~~~~~~~~~~~~~~ 1. View misc/translator/po/de-DE-staff-prog.po . search for "Go to field" (without the ") . no occurrences found 2. Install the language: . cd misc/translator . perl translate install de-DE 3. Change the staff interface language (System preferences > I18N/L18N > enable language. 4. Change interface to the language. 5. Create a new record. 6. Save. 7. The "Go to field" for the error messages is in English. After applying the patch ~~~~~~~~~~~~~~~~~~~~~~~~ 1. Update the language files: perl translate install de-DE 2. misc/translator/po/de-DE-staff-prog.po should have a translatable string (already translated) for "Go to field". 3. Install the language files: perl translate install de-DE 4. Try creating and saving a record again - the "Go to field" should be in German.
Created attachment 128723 [details] [review] Bug 29585: Fix unstranslatable strings in addbiblio.tt This patch makes 'Go to field' and 'Errors' strings translatable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi David, thx for trying to test this! > After applying the patch > ~~~~~~~~~~~~~~~~~~~~~~~~ > > 1. Update the language files: perl translate install de-DE This step will install de-DE again, but the po file won't have been updated to have the string yet. So you need to follow the instructions here first: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Then you should be able to verify, that the string appeared in the po files and you can edit them to translate them if you want. As this one is an easy fix, I am taking the liberty to move it straight to PQA.
Thanks Katrin for the link and how to make his work! Noted for any future bug testing...
Can this please be pushed before next string freeze?
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Missing dependency, not backported to 21.05