Bug 29591 - Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences
Summary: Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 29695
  Show dependency treegraph
 
Reported: 2021-11-29 14:35 UTC by Nick Clemens
Modified: 2022-12-12 21:25 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00,21.11.02,21.05.08


Attachments
Bug 29591: Add autorenew_checkouts column to preferences json (1.77 KB, patch)
2021-11-29 14:42 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 29591: Add autorenew_checkouts column to preferences json (1.82 KB, patch)
2021-12-15 12:14 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2021-11-29 14:35:38 UTC

    
Comment 1 Nick Clemens 2021-11-29 14:42:11 UTC
Created attachment 128081 [details] [review]
Bug 29591: Add autorenew_checkouts column to preferences json

Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be
hidden if a library was not using the feature.

When the column chooser was added, this column was not included.

To test:
1 - Search system preferences for "BorrowerUnwantedFields"
2 - Click the box to change the value
3 - "autorenew_checkouts" is not an option
4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side
5 - Apply patch and restart everythign
6 - Search for the syspref again
7 - Note that now you can select "autorenew_checkouts"
8 - Check the box and save
9 - Confirm the opt out option is no longer visible during patron editing

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 2 Marcel de Rooy 2021-11-29 15:18:55 UTC
Will try to QA very soon. Thx
Comment 3 Jonathan Druart 2021-12-15 10:44:43 UTC
Note that I am suggesting to remove borrowers.json on bug 29695.
Comment 4 Marcel de Rooy 2021-12-15 12:14:05 UTC
Created attachment 128558 [details] [review]
Bug 29591: Add autorenew_checkouts column to preferences json

Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be
hidden if a library was not using the feature.

When the column chooser was added, this column was not included.

To test:
1 - Search system preferences for "BorrowerUnwantedFields"
2 - Click the box to change the value
3 - "autorenew_checkouts" is not an option
4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side
5 - Apply patch and restart everythign
6 - Search for the syspref again
7 - Note that now you can select "autorenew_checkouts"
8 - Check the box and save
9 - Confirm the opt out option is no longer visible during patron editing

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2021-12-15 12:19:49 UTC
(In reply to Jonathan Druart from comment #3)
> Note that I am suggesting to remove borrowers.json on bug 29695.

Thats great. But no reason to skip this patch. This works and can be backported as well.
Comment 6 Jonathan Druart 2021-12-15 12:42:44 UTC
(In reply to Marcel de Rooy from comment #5)
> (In reply to Jonathan Druart from comment #3)
> > Note that I am suggesting to remove borrowers.json on bug 29695.
> 
> Thats great. But no reason to skip this patch. This works and can be
> backported as well.

Of course, it was just something I wanted to highlight here.
I have rebased the patches on top of this one.
Comment 7 Fridolin Somers 2022-01-04 06:59:37 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄
Comment 8 Kyle M Hall 2022-01-07 11:18:04 UTC
Pushed to 21.11.x for 21.11.02
Comment 9 Andrew Fuerste-Henry 2022-01-10 16:00:52 UTC
Pushed to 21.05.x for 21.05.08
Comment 10 Victor Grousset/tuxayo 2022-02-07 11:52:23 UTC
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.