There's a 'libraries' tag when it should be 'library'. This leads to wrong display in the API documentation site [1]. [1] https://api.koha-community.org/#tag/library
Created attachment 128088 [details] [review] Bug 29593: Fix wrong tag in GET /public/libraries spec This makes the documentation look untidy. To test: 1. Open the api/v1/swagger/paths/libraries.json file with your favourite editor. => FAIL: All routes, but this one, have tags: ['library'] 2. Apply this patch => SUCCESS: All routes have tags: ['library'] 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 128089 [details] [review] Bug 29593: Fix wrong tag in GET /public/libraries spec This makes the documentation look untidy. To test: 1. Open the api/v1/swagger/paths/libraries.json file with your favourite editor. => FAIL: All routes, but this one, have tags: ['library'] 2. Apply this patch => SUCCESS: All routes have tags: ['library'] 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Looking at api/v1/swagger/swagger.yaml it seems that we use the plural form for all other tags. Shouldn't we do the reverse and use "libraries" everywhere else instead?
(In reply to Jonathan Druart from comment #3) > Looking at api/v1/swagger/swagger.yaml it seems that we use the plural form > for all other tags. > > Shouldn't we do the reverse and use "libraries" everywhere else instead? Good point, updating the patch.
Created attachment 128151 [details] [review] Bug 29593: Fix wrong tag in GET /public/libraries spec This makes the documentation look untidy. To test: 1. Open the api/v1/swagger/paths/libraries.json file with your favourite editor. => FAIL: All routes, but this one, have tags: ['library'] 2. Apply this patch => SUCCESS: All routes have tags: ['libraries'] 3. swagger.yaml too! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 128210 [details] [review] Bug 29593: Fix wrong tag in GET /public/libraries spec This makes the documentation look untidy. To test: 1. Open the api/v1/swagger/paths/libraries.json file with your favourite editor. => FAIL: All routes, but this one, have tags: ['library'] 2. Apply this patch => SUCCESS: All routes have tags: ['libraries'] 3. swagger.yaml too! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Solid improvement, Passing QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.01
Missing dependencies, not backported to 21.05.x