Created attachment 128111 [details] example To recreate: 1. Do a search that will give you lots of term highlighting, I just searched for 'e' in koha-testing-docker. 2. Go to a record with some MARC 505 notes, this HTML element is 'contentblock'. 3. Notice the CSS pseudo element with this property 'content: "→ ";' 4. The very first time you see a match in the term highlight ( in my case 'e'), the → is added. This is because of this: .contentblock :first-child::before { content: "→ "; }
Created attachment 128146 [details] [review] Bug 29604: Dont add psuedo content to highlighted terms To test: 1. Do a search for something where the search terms will be in the 505 note. 2. Visit the OPAC detail page of the record. 3. The first occurance of the term highlighting will include the CSS pseduo element "→ "; 4. Apply patch 5. Do the stuff to regenerate the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 6. Do 1 & 2 again. 7. No weird psuedo element in the term highlighting
Created attachment 128226 [details] [review] Bug 29604: Dont add psuedo content to highlighted terms To test: 1. Do a search for something where the search terms will be in the 505 note. 2. Visit the OPAC detail page of the record. 3. The first occurance of the term highlighting will include the CSS pseduo element "→ "; 4. Apply patch 5. Do the stuff to regenerate the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 6. Do 1 & 2 again. 7. No weird psuedo element in the term highlighting Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 128706 [details] [review] Bug 29604: Dont add psuedo content to highlighted terms To test: 1. Do a search for something where the search terms will be in the 505 note. 2. Visit the OPAC detail page of the record. 3. The first occurance of the term highlighting will include the CSS pseduo element "→ "; 4. Apply patch 5. Do the stuff to regenerate the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 6. Do 1 & 2 again. 7. No weird psuedo element in the term highlighting Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Pushed to 21.05.x for 21.05.8
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.