BorrowerUnwantedField includes the ability to mark categorycode as unwanted/hidden. If you mark it as unwanted and try to add a new patron you will see an error: "Something went wrong when creating the patron. Check the logs." categorycode must not be hidden
Created attachment 128145 [details] [review] Bug 29617: exclude categorycode from BorrowerUnwantedField To test: 1. Go to BorrowerUnwantedField and select categorycode as unwanted 2. Try adding a new patron, you will see an error message in the staff client "Something went wrong when creating the patron. Check the logs." You will be unable to make a new patron. 3. Apply patch 4. Go to BorrowerUnwantedField, you are unable to exlcude it. Patrons need categorycodes
Created attachment 130351 [details] [review] Bug 29617: exclude categorycode from BorrowerUnwantedField To test: 1. Go to BorrowerUnwantedField and select categorycode as unwanted 2. Try adding a new patron, you will see an error message in the staff client "Something went wrong when creating the patron. Check the logs." You will be unable to make a new patron. 3. Apply patch 4. Go to BorrowerUnwantedField, you are unable to exlcude it. Patrons need categorycodes Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Created attachment 130536 [details] [review] Bug 29617: exclude categorycode from BorrowerUnwantedField To test: 1. Go to BorrowerUnwantedField and select categorycode as unwanted 2. Try adding a new patron, you will see an error message in the staff client "Something went wrong when creating the patron. Check the logs." You will be unable to make a new patron. 3. Apply patch 4. Go to BorrowerUnwantedField, you are unable to exlcude it. Patrons need categorycodes Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
I just ran into this on 21.11. When I tried to change the categorycode of an existing patron I could choose the new category and saving looked ok, but the actual categorycode was not saved. No relevant info in console or logs. Would be nice to have this backported to 21.11.
I think this should be a bug, not an enh?
(In reply to Magnus Enger from comment #6) > I think this should be a bug, not an enh? I agree, a backport for this would be nice.
Pushed to 21.11.x for 21.11.07!
(In reply to Kyle M Hall from comment #8) > Pushed to 21.11.x for 21.11.07! Awesome! Thanks!
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.