Bug 29629 - Remove two unused intranet MODS XSLT sheets
Summary: Remove two unused intranet MODS XSLT sheets
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-03 08:11 UTC by Marcel de Rooy
Modified: 2022-12-12 21:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 29629: Remove two unused MODS XSLT stylesheets (212.49 KB, patch)
2021-12-03 08:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 29629: Remove two unused MODS XSLT stylesheets (212.53 KB, patch)
2022-01-19 12:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2021-12-03 08:11:24 UTC
See bug 29556:

Owen discovered:
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl

These two files appear to be unused. I could only find references to them in .po files.

Lets remove them here.
Comment 1 Marcel de Rooy 2021-12-03 08:18:55 UTC
Created attachment 128203 [details] [review]
Bug 29629: Remove two unused MODS XSLT stylesheets

Follow-up of bug 29556. With thanks to Owen for checking.

> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl
> These two files appear to be unused. I could only find references to them in .po files.

Test plan:
git grep MARC21slim2MODS32
git grep MARC21slim2MODS3
Skip the misc/translator/po references. Note in the second grep that
you only see that MODS3-1 is used in unapi and C4::Record.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2021-12-03 08:19:19 UTC
Trivial: self signoff
Comment 3 Jonathan Druart 2022-01-19 12:33:20 UTC
Created attachment 129600 [details] [review]
Bug 29629: Remove two unused MODS XSLT stylesheets

Follow-up of bug 29556. With thanks to Owen for checking.

> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl
> These two files appear to be unused. I could only find references to them in .po files.

Test plan:
git grep MARC21slim2MODS32
git grep MARC21slim2MODS3
Skip the misc/translator/po references. Note in the second grep that
you only see that MODS3-1 is used in unapi and C4::Record.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Fridolin Somers 2022-01-28 21:13:07 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄