Bug 29671 - Dropbox mode is unchecked after check in confirm on item with Materials specified
Summary: Dropbox mode is unchecked after check in confirm on item with Materials speci...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: geraud.frappier
QA Contact: Testopia
URL:
Keywords:
: 31620 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-12-09 13:52 UTC by Christophe TORIN
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15
Circulation function:


Attachments
Suggested patch (1.15 KB, patch)
2021-12-09 13:52 UTC, Christophe TORIN
Details | Diff | Splinter Review
Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified (2.06 KB, patch)
2022-09-23 20:27 UTC, geraud.frappier
Details | Diff | Splinter Review
Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified (2.11 KB, patch)
2022-09-26 09:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified (2.25 KB, patch)
2022-09-26 14:53 UTC, geraud.frappier
Details | Diff | Splinter Review
Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified (2.35 KB, patch)
2022-09-30 07:38 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe TORIN 2021-12-09 13:52:54 UTC Comment hidden (obsolete)
Comment 1 Marie-Luce Laflamme 2022-09-21 20:46:01 UTC
Both Koha versions 21.05 and 22.05 have this behaviour.

I would be a huge improvement if the drop box mode could stay in memory after the checkin of an item with «material specified» (952$3).
Comment 2 geraud.frappier 2022-09-23 20:27:22 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2022-09-26 09:24:29 UTC
*** Bug 31620 has been marked as a duplicate of this bug. ***
Comment 4 Owen Leonard 2022-09-26 09:51:10 UTC
Created attachment 140974 [details] [review]
Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified

Suggested patch

steps to reproduce :

1) Enable System preference CirConfirmItemParts
2) Go to Circulation > Check in
3) Enable Dropbox mode (Book drop mode) in the Checkin settings
4) Enter a barcode of an item having the 'Materials specified' field
   not empty
5) A Popup is shown, click the confirm button
6) The Dropbox mode (Book drop mode) is now unchecked, but should stay
   checked.

In the template, the modal window lacks the dropboxmode input, so that
it stays on the next page. I attached a patch with my suggested correction.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 geraud.frappier 2022-09-26 14:53:17 UTC
Created attachment 140986 [details] [review]
Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified

Suggested patch

steps to reproduce :

1) Enable System preference CirConfirmItemParts
2) Go to Circulation > Check in
3) Enable Dropbox mode (Book drop mode) in the Checkin settings
4) Enter a barcode of an item having the 'Materials specified' field
   not empty
5) A Popup is shown, click the confirm button
6) The Dropbox mode (Book drop mode) is now unchecked, but should stay
   checked.

In the template, the modal window lacks the dropboxmode input, so that
it stays on the next page. I attached a patch with my suggested correction.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Géraud <geraud.frappier@inlibro.com>
Comment 6 Marcel de Rooy 2022-09-30 07:38:42 UTC
Created attachment 141110 [details] [review]
Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified

Suggested patch

steps to reproduce :

1) Enable System preference CirConfirmItemParts
2) Go to Circulation > Check in
3) Enable Dropbox mode (Book drop mode) in the Checkin settings
4) Enter a barcode of an item having the 'Materials specified' field
   not empty
5) A Popup is shown, click the confirm button
6) The Dropbox mode (Book drop mode) is now unchecked, but should stay
   checked.

In the template, the modal window lacks the dropboxmode input, so that
it stays on the next page. I attached a patch with my suggested correction.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Géraud <geraud.frappier@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Tomás Cohen Arazi (tcohen) 2022-10-03 17:14:39 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 Lucas Gass (lukeg) 2022-12-05 16:46:25 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 9 Arthur Suzuki 2022-12-14 12:04:40 UTC
applied to 21.11 for 21.11.15
Comment 10 Wainui Witika-Park 2022-12-23 00:25:08 UTC
Not released in 21.05.22
Comment 11 Wainui Witika-Park 2023-03-15 00:40:00 UTC
(In reply to wainuiwitikapark from comment #10)
> Not released in 21.05.22

Reverted from 21.05 branch