Created attachment 128374 [details] [review] Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction.
Both Koha versions 21.05 and 22.05 have this behaviour. I would be a huge improvement if the drop box mode could stay in memory after the checkin of an item with «material specified» (952$3).
Created attachment 140964 [details] [review] Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction.
*** Bug 31620 has been marked as a duplicate of this bug. ***
Created attachment 140974 [details] [review] Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 140986 [details] [review] Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Géraud <geraud.frappier@inlibro.com>
Created attachment 141110 [details] [review] Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Géraud <geraud.frappier@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.08
applied to 21.11 for 21.11.15
Not released in 21.05.22
(In reply to wainuiwitikapark from comment #10) > Not released in 21.05.22 Reverted from 21.05 branch