There is no default English sql localization obviously. But why shouldnt we allow it when someone adds a custom script there to do things that are done too for the other languages like de-DE etc. ? Tiny adjustment
DBIx::RunSQL is quite stupid on splitting by newlines btw..
Created attachment 128386 [details] [review] Bug 29673: Allow English sql localization script Test plan: You might want to add a simple SQL statement to your English custom.sql in order to verify the execution. Run a Koha install (in English). Check if the data shows your custom sql action. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
See bug 13669 comment71 showing that you cannot add functions or procedures in a sql file run by DBIx::RunSQL.
Changes one line, adds two comments. More or less a no-op to allow simple customization. Waiting for 10 months. Still applies. Moving it to the next queue..
Created attachment 139164 [details] [review] Bug 29673: Allow English sql localization script Test plan: You might want to add a simple SQL statement to your English custom.sql in order to verify the execution. Run a Koha install (in English). Check if the data shows your custom sql action. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!