Bug 29673 - Allow an English sql localization script
Summary: Allow an English sql localization script
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-09 15:06 UTC by Marcel de Rooy
Modified: 2023-12-28 20:43 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 29673: Allow English sql localization script (1.61 KB, patch)
2021-12-10 08:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 29673: Allow English sql localization script (1.63 KB, patch)
2022-08-15 17:50 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2021-12-09 15:06:53 UTC
There is no default English sql localization obviously. But why shouldnt we allow it when someone adds a custom script there to do things that are done too for the other languages like de-DE etc. ?

Tiny adjustment
Comment 1 Marcel de Rooy 2021-12-09 15:41:27 UTC
DBIx::RunSQL is quite stupid on splitting by newlines btw..
Comment 2 Marcel de Rooy 2021-12-10 08:55:47 UTC
Created attachment 128386 [details] [review]
Bug 29673: Allow English sql localization script

Test plan:
You might want to add a simple SQL statement to your English
custom.sql in order to verify the execution.
Run a Koha install (in English).
Check if the data shows your custom sql action.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2021-12-10 09:14:42 UTC
See bug 13669 comment71 showing that you cannot add functions or procedures in a sql file run by DBIx::RunSQL.
Comment 4 Marcel de Rooy 2022-08-15 12:53:48 UTC
Changes one line, adds two comments. More or less a no-op to allow simple customization. Waiting for 10 months. Still applies.
Moving it to the next queue..
Comment 5 Kyle M Hall 2022-08-15 17:50:23 UTC
Created attachment 139164 [details] [review]
Bug 29673: Allow English sql localization script

Test plan:
You might want to add a simple SQL statement to your English
custom.sql in order to verify the execution.
Run a Koha install (in English).
Check if the data shows your custom sql action.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2022-08-16 13:25:27 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!