In reports menu the 'Show SQL code' button has no right border radius. And if you click you see 'Hide SQL code' button has no left border radius. This is because these are two buttons in a group, hidden or displayed. The CSS ruling border radius is from bootstrap.min.css: .btn-group > .btn:first-child:not(:last-child):not(.dropdown-toggle) 0px A way to fix is to create 2 button groups.
Created attachment 128466 [details] [review] Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct.
Created attachment 128579 [details] [review] Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 128659 [details] [review] Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andreas Roussos <a.roussos@dataly.gr>
Created attachment 128677 [details] [review] Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Pushed to 21.05.x for 21.05.08
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.