Currently all of the sample quotes are by US Presidents and were all said by white men. It would be great to see some diversity in these sample quotes.
Created attachment 128643 [details] [review] Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT
I really love this, thx Aleisha! I had tried to get people to send me quotes at one of the GBSD days, but sadly that didn't work out. Glad to see more diversity, will try to test (or better QA).
Created attachment 128848 [details] [review] Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 129235 [details] [review] Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I was aiming to mostly work on bug fixes... but this is kind of a bug fix for me :)
For another enhancement: we should add a wikipedia link to help discover less known persons.
Created attachment 129712 [details] [review] Bug 29722: (QA follow-up) Replace unusual single quote
I found an unusual single quote character in n°44. Looks like it works but it is more consistent to use usual single quote.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Pushed to 21.05.x for 21.05.11
Love this patch, but please keep in mind that strings added to the installer are now showing up in translations on pootle too (which is pretty awesome, but means they are string changes :) )
(In reply to Katrin Fischer from comment #12) > Love this patch, but please keep in mind that strings added to the installer > are now showing up in translations on pootle too (which is pretty awesome, > but means they are string changes :) ) My apologies for that! For some reason I thought these didn't get translated.
Thanks a lot for more quotes, and cool ones! :D Some of the old ones are really obnoxious >_< > For some reason I thought these didn't get translated. It depends on the translators. On Canada's french and France's french they are just copied as is. Maybe that might change once we reach 100%
Backported: Pushed to 20.11.x branch for 20.11.16
Does this need to be backported to 19.11.x?
(In reply to wainuiwitikapark from comment #16) > Does this need to be backported to 19.11.x? Completely up to you!
Not backported to 19.11.x