To recreate: To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. Notice that console error: datatables.min_21.1200002.js:62 Uncaught TypeError: Cannot set properties of undefined (setting '_DT_CellIndex') If you run the report for a branch WITH subscriptions it works just fine.
Created attachment 128686 [details] [review] Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well
Created attachment 128687 [details] [review] Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 128699 [details] [review] Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice catch :)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Pushed to 21.05.x for 21.05.08
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.