From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED)
Created attachment 128754 [details] [review] Bug 29737: Fix suspend from hold list From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX
Created attachment 128755 [details] [review] Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now.
This is a regression but no idea when it has been introduced!
Created attachment 128780 [details] [review] Bug 29737: Fix suspend from hold list From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david@davidnind.com>
Created attachment 128781 [details] [review] Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 128803 [details] [review] Bug 29737: Fix suspend from hold list From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 128804 [details] [review] Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Cannot recreate issue on 21.05.x. Not backporting. Please request if needed.