It would be useful to be able to see a patron's category in the Holds Queue. This would help libraries avoid filling holds placed on bibs with a mix of item types when the patron has 0 allowed holds for that specific item's item type, as in bugs 11350 and 23172 (reservesallowed = 0, but the patron isn't ineligible per hold_allowed).
+1
Created attachment 129047 [details] [review] Bug 29760: Show patron category on view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category 3. Apply patch 4. Look again, you can now see the patron category in the patron column
(In reply to Lucas Gass from comment #2) > Created attachment 129047 [details] [review] [review] > Bug 29760: Show patron category on view_holdsqueue.tt > > To test: > 1. Have some holds and build the holds queue. > 2. Go to view_holdsqueue.tt, there is no patron category > 3. Apply patch > 4. Look again, you can now see the patron category in the patron column I tested and the patch seems to work according to the test plan. However, I think that it would be better to have a Patron Category column, instead of having the patron category inside the patron column.
Created attachment 129354 [details] [review] Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue.
Created attachment 129414 [details] [review] Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 130541 [details] [review] Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I see HTML classes are : + <th class="hq-patroncategory">Patron category</th> + <td class="hq-patroncategory"> + <td class="hq-patron-category">... Is third one with a dash on purpose ?
(In reply to Fridolin Somers from comment #7) > I see HTML classes are : > + <th class="hq-patroncategory">Patron category</th> > + <td class="hq-patroncategory"> > + <td class="hq-patron-category">... > > Is third one with a dash on purpose ? I think that was a mistake, I will provide a follow-up.
Created attachment 130619 [details] [review] Bug 29760: (follow-up) Fix class name
Pushed to master for 22.05, thanks to everybody involved [U+1F984]