Bug 29832 - Make library column in desk list sortable
Summary: Make library column in desk list sortable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-09 13:24 UTC by Katrin Fischer
Modified: 2022-12-12 21:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 29832: Make library column in desk list sortable (2.09 KB, patch)
2022-01-10 12:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 29832: Make library column in desk list sortable (2.14 KB, patch)
2022-01-10 18:53 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 29832: Make library column in desk list sortable (2.22 KB, patch)
2022-02-01 15:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29832: Use KohaTable (1.68 KB, patch)
2022-02-01 15:39 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-01-09 13:24:11 UTC
It would be nice, if the list of desks under Administration > circulation desks was sortable by library.

Requires  UseCirculationDesks to be turned on.
Comment 1 Owen Leonard 2022-01-10 12:33:25 UTC
Created attachment 129251 [details] [review]
Bug 29832: Make library column in desk list sortable

This patch makes minor updates to the DataTable configuration on the
Circulation Desks Administration page. Redundant options are removed and
existing options are updated to use current DataTables syntax.

To test, apply the patch and make sure that the UseCirculationDesks
system preference is enabled.

- Go to Administration -> Circulation desks.
- Add multiple circulation desks if necessary, at multiple libraries.
- The "Desk" column should be sorted by default, and the "Actions"
  column should not be sortable.
- The "Library" column should be sortable.
Comment 2 Lucas Gass 2022-01-10 18:53:53 UTC
Created attachment 129284 [details] [review]
Bug 29832: Make library column in desk list sortable

This patch makes minor updates to the DataTable configuration on the
Circulation Desks Administration page. Redundant options are removed and
existing options are updated to use current DataTables syntax.

To test, apply the patch and make sure that the UseCirculationDesks
system preference is enabled.

- Go to Administration -> Circulation desks.
- Add multiple circulation desks if necessary, at multiple libraries.
- The "Desk" column should be sorted by default, and the "Actions"
  column should not be sortable.
- The "Library" column should be sortable.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2022-02-01 15:39:14 UTC
Created attachment 130046 [details] [review]
Bug 29832: Make library column in desk list sortable

This patch makes minor updates to the DataTable configuration on the
Circulation Desks Administration page. Redundant options are removed and
existing options are updated to use current DataTables syntax.

To test, apply the patch and make sure that the UseCirculationDesks
system preference is enabled.

- Go to Administration -> Circulation desks.
- Add multiple circulation desks if necessary, at multiple libraries.
- The "Desk" column should be sorted by default, and the "Actions"
  column should not be sortable.
- The "Library" column should be sortable.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2022-02-01 15:39:18 UTC
Created attachment 130047 [details] [review]
Bug 29832: Use KohaTable

NoSort is defined in KohaTable

Also add noExport

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Fridolin Somers 2022-02-11 00:37:55 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄