Some librarians would like style the buttons on the Dverdrive results page differently from one another. I realized this is somewhat difficult to do at the moment because each of those buttons are built by JavaScript and don't include a unique class name or ID. Those buttons are the check-in, check-out, place hold, cancel hold, and download as buttons. If they had an ID it would make it easy to style them.
Created attachment 129288 [details] [review] Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style.
Using the id attribute will create situations where there are multiple identical ids on the page, which isn't allowed. Can you use a class instead?
Created attachment 129324 [details] [review] Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style.
Created attachment 129332 [details] [review] Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
As I can't test Overdrive I am a bit hesitant to try my hands on the rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29845: add IDs to overdrive results action buttons Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js error: Failed to merge in the changes. Patch failed at 0001 Bug 29845: add IDs to overdrive results action buttons
Created attachment 130633 [details] [review] Bug 29845: add classes to overdrive results action buttonswq To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style.
Created attachment 130634 [details] [review] Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style.
Created attachment 130662 [details] [review] Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 130878 [details] [review] Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]