To reproduce: 1. Run: $ kshell k$ prove t/db_dependent/selenium/regressions.t => FAIL: You see several item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905. and Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156.
Created attachment 129348 [details] [review] Bug 29860: Remove item type-related warnings To test: 1. Run: $ kshell k$ prove t/db_dependent/selenium/regressions.t => FAIL: You see several item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more item type warnings 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tomas: What about changing status here ?
(In reply to Marcel de Rooy from comment #2) > Tomas: What about changing status here ? Oops
Created attachment 135218 [details] [review] Bug 29860: Remove item type-related warnings To test: 1. Run: $ kshell k$ prove t/db_dependent/selenium/regressions.t => FAIL: You see several item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more item type warnings 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135221 [details] [review] Bug 29860: Remove item type-related warnings To test: 1. Run: $ kshell k$ prove t/db_dependent/selenium/regressions.t => FAIL: You see several item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more item type warnings 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
pushed to 21.11 for 21.11.07
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved.