Bug 29860 - Useless warnings in regressions.t
Summary: Useless warnings in regressions.t
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-12 14:13 UTC by Tomás Cohen Arazi
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.01


Attachments
Bug 29860: Remove item type-related warnings (1.36 KB, patch)
2022-01-12 14:16 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 29860: Remove item type-related warnings (1.41 KB, patch)
2022-05-19 19:57 UTC, David Nind
Details | Diff | Splinter Review
Bug 29860: Remove item type-related warnings (1.50 KB, patch)
2022-05-20 06:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2022-01-12 14:13:16 UTC
To reproduce:
1. Run:
   $ kshell
  k$ prove t/db_dependent/selenium/regressions.t
=> FAIL: You see several
item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905.
and
Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156.
Comment 1 Tomás Cohen Arazi 2022-01-12 14:16:19 UTC
Created attachment 129348 [details] [review]
Bug 29860: Remove item type-related warnings

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/selenium/regressions.t
=> FAIL: You see several
item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905.
2. Apply this patch
3. Repeat 1
=> SUCCESS: No more item type warnings
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Marcel de Rooy 2022-05-19 06:16:33 UTC
Tomas: What about changing status here ?
Comment 3 Tomás Cohen Arazi 2022-05-19 11:15:07 UTC
(In reply to Marcel de Rooy from comment #2)
> Tomas: What about changing status here ?

Oops
Comment 4 David Nind 2022-05-19 19:57:41 UTC
Created attachment 135218 [details] [review]
Bug 29860: Remove item type-related warnings

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/selenium/regressions.t
=> FAIL: You see several
item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905.
2. Apply this patch
3. Repeat 1
=> SUCCESS: No more item type warnings
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Marcel de Rooy 2022-05-20 06:32:10 UTC
Created attachment 135221 [details] [review]
Bug 29860: Remove item type-related warnings

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/selenium/regressions.t
=> FAIL: You see several
item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905.
2. Apply this patch
3. Repeat 1
=> SUCCESS: No more item type warnings
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Tomás Cohen Arazi 2022-06-01 19:02:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-06-10 14:44:13 UTC
Pushed to 22.05.x for 22.05.01
Comment 8 Arthur Suzuki 2022-06-20 08:51:07 UTC
pushed to 21.11 for 21.11.07
Comment 9 Victor Grousset/tuxayo 2022-06-25 21:55:05 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.