I would like to update the authorized values administration template so that it has consistent indentation. It needs to have some tabs replaced with spaces and to have trailing spaces removed.
Created attachment 129361 [details] [review] Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values.
Created attachment 129362 [details] [review] Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality.
Created attachment 129631 [details] [review] Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 129632 [details] [review] Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 130062 [details] [review] Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130063 [details] [review] Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I'm really sorry patch does not apply anymore on master. Looks like it is because of Bug 29859. I'll push fastly after rebase.
Created attachment 130444 [details] [review] Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130445 [details] [review] Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks a lot Owen. This template looks a looooot more clear now ;)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]