Bug 29879 - Make sure objects moved to old_* is not tried to be saved again
Summary: Make sure objects moved to old_* is not tried to be saved again
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on: 29525
Blocks:
  Show dependency treegraph
 
Reported: 2022-01-13 18:13 UTC by Tomás Cohen Arazi
Modified: 2022-01-13 18:14 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2022-01-13 18:13:44 UTC
When a checkout or a hold is completed, Koha moves the issues/reserves row to their old_* counterpart. We are leaning towards chaining calls to simplify code, but calling methods like Koha::Hold->cancel or Koha::Hold->fill should somehow mark the current object so trying to store it by mistake should raise an exception.