Bug 29882 - Remove unrequired package definitions in list-deps script
Summary: Remove unrequired package definitions in list-deps script
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Mason James
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-14 06:59 UTC by Mason James
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 29882 - remove unrequired package definitions in list-deps script (1.31 KB, patch)
2022-01-14 07:01 UTC, Mason James
Details | Diff | Splinter Review
Bug 29882 - remove unrequired package definitions in list-deps script (1.49 KB, patch)
2022-08-26 06:52 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 29882 - remove unrequired package definitions in list-deps script (1.54 KB, patch)
2022-09-02 17:51 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2022-01-14 06:59:42 UTC
to test...

- apply patch, rebuild new package

- install new koha-common pkg on successfully
Comment 1 Mason James 2022-01-14 07:01:57 UTC
Created attachment 129462 [details] [review]
Bug 29882 - remove unrequired package definitions in list-deps script

to test...

- apply patch, rebuild new package

- install new koha-common pkg successfully
Comment 2 Magnus Enger 2022-08-26 06:52:12 UTC
Created attachment 139814 [details] [review]
Bug 29882 - remove unrequired package definitions in list-deps script

to test...

- apply patch, rebuild new package

- install new koha-common pkg successfully

Signed-off-by: Magnus Enger <magnus@libriotech.no>
I did not build packages, just grep'ed the source to check that
these modules are no longer used. Please set back to "Needs
signoff" if this is not considered good enough.
Comment 3 Katrin Fischer 2022-08-28 09:30:20 UTC
Had a look, but cannot build a package to try and removing Mojolicious and Swagger appears a little counter-intuitive. Leaving to another QA person!
Comment 4 David Cook 2022-08-29 01:43:51 UTC
I take it that this is due to these deps being picked up out of the cpanfile?
Comment 5 Mason James 2022-08-31 07:54:17 UTC
(In reply to David Cook from comment #4)
> I take it that this is due to these deps being picked up out of the cpanfile?

yes correct, both modules are referenced the cpanfile

requires 'Mojolicious', '8.12';
requires 'Mojolicious::Plugin::OpenAPI', '2.16';

ps: swagger2 has been renamed to openapi :)
Comment 6 Kyle M Hall 2022-09-02 17:51:46 UTC
Created attachment 140176 [details] [review]
Bug 29882 - remove unrequired package definitions in list-deps script

to test...

- apply patch, rebuild new package

- install new koha-common pkg successfully

Signed-off-by: Magnus Enger <magnus@libriotech.no>
I did not build packages, just grep'ed the source to check that
these modules are no longer used. Please set back to "Needs
signoff" if this is not considered good enough.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2022-09-07 20:21:36 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!