to test... - apply patch, rebuild new package - install new koha-common pkg on successfully
Created attachment 129462 [details] [review] Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully
Created attachment 139814 [details] [review] Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully Signed-off-by: Magnus Enger <magnus@libriotech.no> I did not build packages, just grep'ed the source to check that these modules are no longer used. Please set back to "Needs signoff" if this is not considered good enough.
Had a look, but cannot build a package to try and removing Mojolicious and Swagger appears a little counter-intuitive. Leaving to another QA person!
I take it that this is due to these deps being picked up out of the cpanfile?
(In reply to David Cook from comment #4) > I take it that this is due to these deps being picked up out of the cpanfile? yes correct, both modules are referenced the cpanfile requires 'Mojolicious', '8.12'; requires 'Mojolicious::Plugin::OpenAPI', '2.16'; ps: swagger2 has been renamed to openapi :)
Created attachment 140176 [details] [review] Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully Signed-off-by: Magnus Enger <magnus@libriotech.no> I did not build packages, just grep'ed the source to check that these modules are no longer used. Please set back to "Needs signoff" if this is not considered good enough. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!