As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the item types administration page.
Created attachment 131895 [details] [review] Bug 29998: Replace the use of jQueryUI tabs on item types administration page This patch updates the item type edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Unrelated: The patch removes an invalid "type" attribute from a <select> element. - Go to Administration -> Item types in the staff interface. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g. https://via.placeholder.com/50/FF0000/FFFFFF.png ) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view.
Created attachment 131981 [details] [review] Bug 29998: Replace the use of jQueryUI tabs on item types administration page This patch updates the item type edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Unrelated: The patch removes an invalid "type" attribute from a <select> element. - Go to Administration -> Item types in the staff interface. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g. https://via.placeholder.com/50/FF0000/FFFFFF.png ) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Tested and QAed with bug 29999.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]