Instead of showing the library the desk was added to, on editing a desk, it always shows the library the user is currently logged in as preselected. Requires UseCirculationDesks to be activated.
Created attachment 130699 [details] [review] Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to.
Hi Lucas, thx for picking this one up! I believe there is a small regression with the fix: When you are adding a desk, preselecting the current library makes sense, but now the empty option is preselected. Is there a chance we could distinguish between adding and editing as we do for other forms?
Created attachment 131529 [details] [review] Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. 6. Try making a new desk and make sure it defaults to the logged in branch
Created attachment 132331 [details] [review] Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. 6. Try making a new desk and make sure it defaults to the logged in branch Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Seems ok for me : I didn't notice the regression Katrin talked about. Thanks Lucas !
I think it was fixed in the lastest version of the patch - will double-check in QA :)
Created attachment 132371 [details] [review] Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. 6. Try making a new desk and make sure it defaults to the logged in branch Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05