When you try to search reports by date it results with 500 error. C4::Reports::Guided::get_saved_reports(): DBI Exception: DBD::mysql::db selectall_arrayref failed: called with 3 bind variables when 2 are needed at /usr/share/koha/intranet/cgi-bin/reports/guided_reports.pl line 138
Created attachment 130825 [details] [review] Bug 30129: remove the third required date that was causing 500 error This problem appeared because of this commit: Bug 14435 Add the ability to store result's report cf9031711282f4be23e4a639797d0fd178940e1f This patch fixes it by removing the third $date that wasn't removed back then. To reproduce: 1) Head over to Reports page. 2) Search for report by date. It should cause 500 error. 3) Apply the patch. 4) Repeat the search again, it should be working now.
Created attachment 130904 [details] [review] Bug 30129: remove the third required date that was causing 500 error This problem appeared because of this commit: Bug 14435 Add the ability to store result's report cf9031711282f4be23e4a639797d0fd178940e1f This patch fixes it by removing the third $date that wasn't removed back then. To reproduce: 1) Head over to Reports page. 2) Search for report by date. It should cause 500 error. 3) Apply the patch. 4) Repeat the search again, it should be working now. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 130958 [details] [review] Bug 30129: remove the third required date that was causing 500 error This problem appeared because of this commit: Bug 14435 Add the ability to store result's report cf9031711282f4be23e4a639797d0fd178940e1f This patch fixes it by removing the third $date that wasn't removed back then. To reproduce: 1) Head over to Reports page. 2) Search for report by date. It should cause 500 error. 3) Apply the patch. 4) Repeat the search again, it should be working now. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130959 [details] [review] Bug 30129: Add test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 131005 [details] [review] Bug 30129: Add test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Fridolin Somers from comment #5) > Created attachment 131005 [details] [review] [review] > Bug 30129: Add test > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Fix of small type 'fiter' instead of 'filter'
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Pushed to 21.05.x for 21.05.12
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.