On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear.
Created attachment 131096 [details] [review] Bug 30147: Fix modules usage in opac-detail.pl On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. In opac-detail.pl, use C4::Search is missing searchResults and getRecords
Not a very generalized test plan yet, but what triggers it for me: * Search for 'e' in simple search on the OPAC * Go to page 10 using the link in the paging on top of results * Go to any detail page from here - boom!
Created attachment 131138 [details] [review] Bug 30147: Fix modules usage in opac-detail.pl On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. In opac-detail.pl, use C4::Search is missing searchResults and getRecords To test: - Search for something that gives several result pages in OPAC, example: e - Switch to one of the last pages using link on top of results, example: 10 - Open any of the records listed in detail view - Verify that the error is shown - Apply patch and repeat, error is gone and browsing behaves as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 131186 [details] [review] Bug 30147: Fix modules usage in opac-detail.pl On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. In opac-detail.pl, use C4::Search is missing searchResults and getRecords To test: - Search for something that gives several result pages in OPAC, example: e - Switch to one of the last pages using link on top of results, example: 10 - Open any of the records listed in detail view - Verify that the error is shown - Apply patch and repeat, error is gone and browsing behaves as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another trivial fix, well spotted. PQA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.04
This seems like it depends on bug 11175? Or at least needs a rebase due to changes there. Not backporting to 21.05, request if needed.