The "Search cities" filter in the header is not taken into account and all the cities are displayed.
Created attachment 131036 [details] [review] Bug 30164: Fix datatable wrapper when no filter passed This problem appears (at least) on the cities list view: If you pass a filter in the "Search cities" filter in the header, it won't be taken into account and all the cities will be displayed. There are two problems. First we are passing an "empty" q=[] in the body, the filter from the header is passed as URL parameters. We should not need to pass the q if it's empty. Then the main problem is coming from a bug in Koha::REST::Plugin::Query but I didn't manage to track it down. If we have two 2 passed, only the second one will be used. We are certainly using a hash somewhere we should not. This patch is fixing the bug but not on the correct side. A follow-up bug should take care of the main problem at lower level. Test plan: Hit /admin/cities.pl Create some cities Use the filter in the header of the page and submit => Without this patch all cities are retrieved => With this patch applied only the relevant cities are displayed.
Created attachment 131097 [details] [review] Bug 30164: Fix datatable wrapper when no filter passed This problem appears (at least) on the cities list view: If you pass a filter in the "Search cities" filter in the header, it won't be taken into account and all the cities will be displayed. There are two problems. First we are passing an "empty" q=[] in the body, the filter from the header is passed as URL parameters. We should not need to pass the q if it's empty. Then the main problem is coming from a bug in Koha::REST::Plugin::Query but I didn't manage to track it down. If we have two 2 passed, only the second one will be used. We are certainly using a hash somewhere we should not. This patch is fixing the bug but not on the correct side. A follow-up bug should take care of the main problem at lower level. Test plan: Hit /admin/cities.pl Create some cities Use the filter in the header of the page and submit => Without this patch all cities are retrieved => With this patch applied only the relevant cities are displayed. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 131104 [details] [review] Bug 30164: Fix datatable wrapper when no filter passed This problem appears (at least) on the cities list view: If you pass a filter in the "Search cities" filter in the header, it won't be taken into account and all the cities will be displayed. There are two problems. First we are passing an "empty" q=[] in the body, the filter from the header is passed as URL parameters. We should not need to pass the q if it's empty. Then the main problem is coming from a bug in Koha::REST::Plugin::Query but I didn't manage to track it down. If we have two 2 passed, only the second one will be used. We are certainly using a hash somewhere we should not. This patch is fixing the bug but not on the correct side. A follow-up bug should take care of the main problem at lower level. Test plan: Hit /admin/cities.pl Create some cities Use the filter in the header of the page and submit => Without this patch all cities are retrieved => With this patch applied only the relevant cities are displayed. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.04
Pushed to 21.05.x for 21.05.13
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.