Bug 30204 - Add subtitle to serial subscription search
Summary: Add subtitle to serial subscription search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30302 30466
  Show dependency treegraph
 
Reported: 2022-03-01 16:09 UTC by Lucas Gass
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Adds the biblio.subtitle to the 'Title' column on serial-search.pl.
Version(s) released in:
22.05.00,21.11.07


Attachments
Bug 30204: Add subtitle to serial search results (2.30 KB, patch)
2022-03-01 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30204: Add subtitle to serial search results (2.34 KB, patch)
2022-03-10 14:57 UTC, Shi Yao Wang
Details | Diff | Splinter Review
Bug 30204: Add subtitle to serial search results (2.40 KB, patch)
2022-04-02 23:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 30204: Add unit test (1.60 KB, patch)
2022-04-05 16:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 30204: Add unit test (1.64 KB, patch)
2022-04-05 17:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30204: Add unit test (1.70 KB, patch)
2022-04-11 22:51 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 30204: Add subtitle to serial search results (2.46 KB, patch)
2022-04-11 22:52 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-03-01 16:09:02 UTC
On serials-search.pl when one does a serial search the results will display the title of the connected biblio but it will not display the biblio.subtitle, it would be handy if it did show the subtitle along with the title.
Comment 1 Lucas Gass 2022-03-01 16:14:54 UTC
Created attachment 131198 [details] [review]
Bug 30204: Add subtitle to serial search results

To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Notice the subtitle doesn't appear.
4. Apply patch and restart_all
5. Again try step 2.
6. Notice the subtitle appears alongside the title now.
7. Make sure it still sorts that column correctly.
Comment 2 Shi Yao Wang 2022-03-10 14:57:05 UTC
Created attachment 131560 [details] [review]
Bug 30204: Add subtitle to serial search results

To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Notice the subtitle doesn't appear.
4. Apply patch and restart_all
5. Again try step 2.
6. Notice the subtitle appears alongside the title now.
7. Make sure it still sorts that column correctly.

Signed-off-by: shiyao <shiyao@inlibro.com>
Comment 3 Katrin Fischer 2022-04-02 23:20:27 UTC
Created attachment 132907 [details] [review]
Bug 30204: Add subtitle to serial search results

To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Notice the subtitle doesn't appear.
4. Apply patch and restart_all
5. Again try step 2.
6. Notice the subtitle appears alongside the title now.
7. Make sure it still sorts that column correctly.

Signed-off-by: shiyao <shiyao@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-04-02 23:25:26 UTC
This works great!

But as the patches include a change to SearchSubscriptions in Serials.pm, we should probably have a small addition to the unit tests.
Comment 5 Kyle M Hall 2022-04-05 16:54:51 UTC
Created attachment 132979 [details] [review]
Bug 30204: Add unit test
Comment 6 Lucas Gass 2022-04-05 17:01:35 UTC
Created attachment 132981 [details] [review]
Bug 30204: Add unit test

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Victor Grousset/tuxayo 2022-04-11 22:51:57 UTC
Created attachment 133201 [details] [review]
Bug 30204: Add unit test

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 8 Victor Grousset/tuxayo 2022-04-11 22:52:02 UTC
Created attachment 133202 [details] [review]
Bug 30204: Add subtitle to serial search results

To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Notice the subtitle doesn't appear.
4. Apply patch and restart_all
5. Again try step 2.
6. Notice the subtitle appears alongside the title now.
7. Make sure it still sorts that column correctly.

Signed-off-by: shiyao <shiyao@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 9 Victor Grousset/tuxayo 2022-04-11 22:52:46 UTC
Works, qa script happy, code looks good, passing QA :)
Comment 10 Fridolin Somers 2022-04-21 06:44:06 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄
Comment 11 Kyle M Hall 2022-05-27 14:47:12 UTC
Pushed to 21.11.x for 21.11.07!
Comment 12 Victor Grousset/tuxayo 2022-06-25 21:36:36 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.