In the Checkout Settings area of the checkout screen, there's a checkbox to make an individual checkout auto-renew. For libraries that don't wish to use auto-renewal at all and don't have the cron enabled, it would be good to have a system preference to remove this checkbox. It can be hidden with jQuery or CSS, but fully disabling it would be preferable.
Created attachment 131388 [details] [review] Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal.
Created attachment 131389 [details] [review] Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal.
Created attachment 131618 [details] [review] Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. Signed-off-by: Kelly mcElligott <kelly@bywatersolutions.com>
Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com>
+ INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`, `type` ) VALUES('AllowSetAutomaticRenewal', '1', '|yes|no', 'Allow or Prevent staff from flagging items for autorenewal on the checkout page', 'YesNo') | before yes seems unneeded Allow or Prevent should probably be Allow or prevent No blocker
+ # Finished adding system preference AllowSetAutomaticRenewal + say $out "Added system preference AllowSetAutomaticRenewal"; Not needed. You just repeat yourself here.
+('AllowSetAutomaticRenewal','1',NULL,'If ON, allows staff to set items for automatic renewal on the check out page','YesNo'), Other description. Not consistent.
(In reply to Marcel de Rooy from comment #5) > | before yes seems unneeded Actually it is a YesNo, so there should be no choices.
Created attachment 133353 [details] [review] Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. Signed-off-by: Kelly mcElligott <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 133354 [details] [review] Bug 30226: (QA follow-up) Sync atomicupdate with sysprefs.sql Description and remove choices. Set items => flag items (as in circulation.pref) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 133507 [details] [review] Bug 30226: (follow-up) Remove text from database update The text displayed by database update is not really helpful. And it will be incorrect if update is run several times.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]