When OPACSuggestionMandatoryFields includes branchcode the dropdown should default to an empty value which will force the user to make a choice regarding branchcode.
Created attachment 131525 [details] [review] Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch https://bugs.koha-community.org/show_bug.cgi?id=29795
Created attachment 131526 [details] [review] Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch
Created attachment 131580 [details] [review] Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch Signed-off-by: shiyao <shiyao@inlibro.com>
Created attachment 132615 [details] [review] Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch Signed-off-by: shiyao <shiyao@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Filed bug 32249, reporting that this doesn't work as anticipated. The dropdown defaults to patron home branch, not an empty value.