Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters.
Created attachment 131503 [details] [review] Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list.
Created attachment 131504 [details] [review] Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on, PatronAutoComplete set to 'Try. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list.
Created attachment 131509 [details] [review] Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on, PatronAutoComplete set to 'Try. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 132184 [details] [review] Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on, PatronAutoComplete set to 'Try. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, no regressions found. PQA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05