(Almost) duplicated line may cause side-effect of shifting parameters and values in a hash. Causing warnings like: [2022/03/07 15:44:13] [WARN] Problem = a value of mana_id has been passed to param without key at /usr/share/koha/C4/Templates.pm line 138. [2022/03/07 15:44:13] [WARN] Problem = a value of mana_comments has been passed to param without key at /usr/share/koha/C4/Templates.pm line 138. Simple fix
Created attachment 131522 [details] [review] Bug 30253: Remove a double mana_success parameter Remove the line without the scalar. Test plan: Just look at the code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Self SO: trivial
Created attachment 131962 [details] [review] Bug 30253: Remove a double mana_success parameter Remove the line without the scalar. Test plan: Just look at the code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05