We find ourselves using the OPACUserJS and OPACUserCSS system preferences quite often in conjunction with the News tool and HTML Customisation tool. It would be great if they were easy to access while making changes in these tools.
Created attachment 131648 [details] [review] Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. To test: 1. In the staff client, go to Tools -> News. Notice there is a button to add a New entry. Confirm this button is also there when you go to Tools -> HTML customisations. 2. Apply the patch and refresh the page. 3. Confirm there are now two new buttons to take you to OPACUserJS and OPACUserCSS. Confirm these buttons take you to the correct system preference. Sponsored-by: Catalyst IT
I think the links should be wrapped in a permissions check. My preference, I think, would be for the links to be smaller text links alongside the "See: News" links, but that's just a suggestion. My reasoning is that *usually* the buttons are reserved for "actions" not navigation.
Created attachment 131698 [details] [review] Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. These links can be enabled or disabled with the new system preference OPACEnhancementPreferencesLinks. To test: 1. Apply the patch and update the database to apply the new system preference. 2. In the staff client, go to Tools -> Additional Contents (either News or HTML customisations). Notice there is a link "See News" or "See HTML customisations". 3. Go to Koha Administration -> system preferences -> Tools tab, find the OPACEnhancementPreferencesLinks system preference. Confirm it is disabled by default. Enable it (set to 'provide'). 4. Go back to Tools -> Additional contents. Confirm there are now links to "See OPACUserCSS" and "See OPACUserJS". Sponsored-by: Catalyst IT
Created attachment 131704 [details] [review] Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. To test: 1. In the staff client, go to Tools -> News. Notice there is a button to add a New entry. Confirm this button is also there when you go to Tools -> HTML customisations. 2. Apply the patch and refresh the page. 3. Confirm there are now two new buttons to take you to OPACUserJS and OPACUserCSS. Confirm these buttons take you to the correct system preference. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 131705 [details] [review] Bug 30288: (follow-up) Add permissions check This follow-up wraps the system preference links in a check for "parameters_manage_sysprefs" permission so that the links don't display to those without permission to access system preferences.
(In reply to Aleisha Amohia from comment #3) > These links can be enabled or disabled with the new system > preference OPACEnhancementPreferencesLinks. I'm sorry for creating confusion Aleisha, I wasn't asking for a system preference. I've restored your original patch and added a follow-up. Please take a look and see if you agree.
Created attachment 131765 [details] [review] Bug 30288: (follow-up) Add permissions check This follow-up wraps the system preference links in a check for "parameters_manage_sysprefs" permission so that the links don't display to those without permission to access system preferences. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Created attachment 133355 [details] [review] Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. To test: 1. In the staff client, go to Tools -> News. Notice there is a button to add a New entry. Confirm this button is also there when you go to Tools -> HTML customisations. 2. Apply the patch and refresh the page. 3. Confirm there are now two new buttons to take you to OPACUserJS and OPACUserCSS. Confirm these buttons take you to the correct system preference. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Bug 30288: (follow-up) Add permissions check This follow-up wraps the system preference links in a check for "parameters_manage_sysprefs" permission so that the links don't display to those without permission to access system preferences. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Ah this patch adds pipes as separator. Please use CSS for this, like in #moresearches : https://git.koha-community.org/Koha-community/Koha/src/commit/833c9efee0c0e01a0223318b578efa77272ed958/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss#L377
Created attachment 133510 [details] [review] Bug 30288: (follow-up) Use CSS for separator pipes
Created attachment 133612 [details] [review] Bug 28786: Don't set auth_method to NULL in ->anonymize DBI Exception: DBD::mysql::st execute failed: Column 'auth_method' cannot be null caught by t/db_dependent/Koha/Patrons.t Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 133613 [details] [review] Bug 30288: (follow-up) Use CSS for separator pipes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
It appears like the first patch was already pushed, so only the follow-up is needed now: https://git.koha-community.org/Koha-community/Koha/commit/aa1def3180f8bc2b0d08b0ac2e57bed29e47d27a
Created attachment 133783 [details] [review] Bug 30288: (follow-up) Use CSS for separator pipes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #13) > It appears like the first patch was already pushed, so only the follow-up is > needed now: > > https://git.koha-community.org/Koha-community/Koha/commit/ > aa1def3180f8bc2b0d08b0ac2e57bed29e47d27a Oups sorry for that. I've pushed follow-up and will update status. Very nice btw ;)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]