Bug 30333 - Move view actions on acquisitions receipt summary page into menu
Summary: Move view actions on acquisitions receipt summary page into menu
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/parcel.pl?invoice...
Keywords:
Depends on:
Blocks: 16640
  Show dependency treegraph
 
Reported: 2022-03-22 13:30 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 30333: Move view actions on acquisitions receipt summary page into menu (6.20 KB, patch)
2022-03-22 13:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30333: Move view actions on acquisitions receipt summary page into menu (6.24 KB, patch)
2022-05-15 22:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 30333: Move view actions on acquisitions receipt summary page into menu (6.32 KB, patch)
2022-05-18 14:01 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-03-22 13:30:55 UTC
In an attempt to resurrect bug Bug 16640, "Move actions on acquisitions receipt summary page into menu," I'm going to split off the change affecting the "view" options (Order, MARC, and Card).
Comment 1 Owen Leonard 2022-03-22 13:37:23 UTC
Created attachment 132022 [details] [review]
Bug 30333: Move view actions on acquisitions receipt summary page into menu

This patch moves the "views" group of links (MARC, Card, and Order) into
a menu button. The patch also makes some corrections to the modal markup
and handling to fix a display error.

To test you must have a basket or baskets with multiple titles on order,
both received and pending.

- Apply the patch and go to Acquisitions -> Vendor -> Receive shipment
  -> Receive a new shipment (or open an existing invoice).
- In the list of pending orders:
  - Test the 'View' menu for multiple titles. The 'Order,' 'MARC,' and
    'Card' menu items should work correctly.
Comment 2 David Nind 2022-05-15 22:53:53 UTC
Created attachment 135011 [details] [review]
Bug 30333: Move view actions on acquisitions receipt summary page into menu

This patch moves the "views" group of links (MARC, Card, and Order) into
a menu button. The patch also makes some corrections to the modal markup
and handling to fix a display error.

To test you must have a basket or baskets with multiple titles on order,
both received and pending.

- Apply the patch and go to Acquisitions -> Vendor -> Receive shipment
  -> Receive a new shipment (or open an existing invoice).
- In the list of pending orders:
  - Test the 'View' menu for multiple titles. The 'Order,' 'MARC,' and
    'Card' menu items should work correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2022-05-18 14:01:50 UTC
Created attachment 135115 [details] [review]
Bug 30333: Move view actions on acquisitions receipt summary page into menu

This patch moves the "views" group of links (MARC, Card, and Order) into
a menu button. The patch also makes some corrections to the modal markup
and handling to fix a display error.

To test you must have a basket or baskets with multiple titles on order,
both received and pending.

- Apply the patch and go to Acquisitions -> Vendor -> Receive shipment
  -> Receive a new shipment (or open an existing invoice).
- In the list of pending orders:
  - Test the 'View' menu for multiple titles. The 'Order,' 'MARC,' and
    'Card' menu items should work correctly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2022-07-20 13:11:20 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-08-23 20:07:13 UTC
Enhancement will not be backported to 22.05.x series unless requested
Comment 6 Katrin Fischer 2022-08-23 20:58:59 UTC
Might require an updated screenshot.
Comment 7 Caroline Cyr La Rose 2023-05-09 18:30:45 UTC
Screenshots in the current manual seem to include this change.