the help page of bulkmarcimport.pl doesnt use double dashes for multi-character options. Id like to update the help info and add multi-character options where they are missing. (e.g. --help for -h)
Created attachment 132127 [details] [review] patch 0001 fix indentation
Created attachment 132128 [details] [review] use double dashes use double dashes, add some multi char options where only a single char option was available e.g. --help for -h
powered by HKS3 (www.koha-support.eu)
Created attachment 132130 [details] [review] more double dashes
Don't forget to switch to "Needs sign-off" once this is ready for testing!
A couple failures from the QA script: FAIL misc/migration_tools/bulkmarcimport.pl FAIL forbidden patterns forbidden pattern: tab char (line 579) Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - 23a34f0d0b * Commit title does not start with 'Bug XXXXX: ' - 6b73fdeb22 * Commit title does not start with 'Bug XXXXX: ' - 7d5ade6229 Can these be fixed please?
Created attachment 160492 [details] [review] Bug 30349: Tidy bulkmarcimport.pl to fix indentations Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 160493 [details] [review] Bug 30349: Use double dash for multi character option names Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 160494 [details] [review] Bug 30349: More double dashes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Rebased, added proper commit lines and signed off
Created attachment 160913 [details] [review] Bug 30349: Tidy bulkmarcimport.pl to fix indentations Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 160914 [details] [review] Bug 30349: Use double dash for multi character option names Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 160915 [details] [review] Bug 30349: More double dashes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 160916 [details] [review] Bug 30349: Add missing double dash (--delete) to POD Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 24.05! Well done everyone, thank you!
No backport to 23.11.x